| Turnstep | |
| Mar 21 2011, 7:36 PM |
| F28293457: Screenshot from 2019-02-27 11-34-41_2.png | |
| Feb 27 2019, 10:46 AM |
When installing using Postgres, a change to the database port field is not respected, and always tries the default, 5432. A reload or retry does pick up the new port.
Version: 1.18.x
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45225
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Invalid | None | T2384 [REPLACED BY TAG] PostgreSQL/pgsql support (tracking) | ||
| Duplicate | None | T30162 Installer does not respect initial DBport declaration | ||
| · · · |
karun.84 wrote:
patch to include constructor in installer
Hello,
I have begun working on a patch to change the constructor for open(...) for the database to include the port number.
Currently the installer works correctly with the patch. However once installed, MediaWiki is unable to connect to the database.
Is someone able to point me into the right direction with this?
Regards
Karun
attachment 28162.patch ignored as obsolete
Verified the two line change to phase3/includes/installer/PostgresInstaller.php in r89859 fixes this for me, FWIW.
sumanah wrote:
Karun, it would be great if you would submit this into Git and Gerrit:
https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch
Push as a draft commit to Gerrit as https://gerrit.wikimedia.org/r/#/c/8906/
Unfortunately, LocalBalancer.php fails on this:
$ php maintenance/eval.php
$z = wfGetDB(-2);
DB connection error: No database connection
Backtrace:
#0 /usr/home/saper/public_html/pg/w/includes/db/LoadBalancer.php(749): DatabaseBase->reportConnectionError('Unknown error (...')
#1 /usr/home/saper/public_html/pg/w/includes/db/LoadBalancer.php(509): LoadBalancer->reportConnectionError(Object(DatabasePostgres))
#2 /usr/home/saper/public_html/pg/w/includes/GlobalFunctions.php(3562): LoadBalancer->getConnection(-2, Array, false)
#3 /usr/home/saper/public_html/pg/w/maintenance/eval.php(72) : eval()'d code(1): wfGetDB(-2)
#4 /usr/home/saper/public_html/pg/w/maintenance/eval.php(72): eval()
#5 {main}
so I can't even run update.php
Needs more work on the LoadBalancer.php issue.
sumanah wrote:
Comment on attachment 9410
patch to include constructor in installer
Patch is now in Gerrit.
Change 8906 abandoned by Hashar:
(bug 28162) Installer ignores initial DBport
Reason:
Cleaning up very old change. Feel free to resurrect if there is any interest in finishing this.
Change 339594 had a related patch set uploaded (by Krinkle):
installer: Fix "relation 'user' does not exist" error for Postgres
Change 339594 merged by jenkins-bot:
installer: Fix "relation 'user' does not exist" error for Postgres
Change 574911 had a related patch set uploaded (by saper; owner: saper):
[mediawiki/core@master] PostgreSQL installer should not ignore port setting
Change 574911 merged by jenkins-bot:
[mediawiki/core@master] installer: PostgreSQL installer should respect a custom port
Change 619607 had a related patch set uploaded (by Legoktm; owner: saper):
[mediawiki/core@REL1_35] installer: PostgreSQL installer should respect a custom port
Change 619607 merged by jenkins-bot:
[mediawiki/core@REL1_35] installer: PostgreSQL installer should respect a custom port
