Page MenuHomePhabricator

Review and enable CLDR extension
Closed, ResolvedPublic

Description

This is logged as an action item, after noticing it on bug 22984

I've got a reasonable feeling that this would be useful for other places too...

Also for bug 16699, related to babel...


Version: unspecified
Severity: enhancement

Details

Reference
bz28176

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:28 PM
bzimport set Reference to bz28176.
bzimport added a subscriber: Unknown Object (MLST).

Please guard the PHP file inclusions against path traversal, like what we now do in the core. You can use Language::isValidBuiltInCode().

Otherwise looks fine. My patch in r84664 should be backported so we will know if there is any performance problem.

r85598 does the path inclusion protection

Is this ok now?

I suspect we can just tag/branch it from the trunk copy to bring this into 1.17wmf1?

OK per Tim, deployed to all wikis by me just now.