Page MenuHomePhabricator

No more JavaScript on frwiki (ResourceLoader serves invalid code)
Closed, ResolvedPublic

Description

Hello,

It looks like there is a bug in ResourceLoader (or in some JavaScript minifier) that cause the valid Medawiki:Common.js of frwiki to become invalid.

Valid (at least looks like it is):
http://bits.wikimedia.org/fr.wikipedia.org/load.php?debug=true&lang=fr&modules=site&only=scripts

Invalid (sure it is not):
http://bits.wikimedia.org/fr.wikipedia.org/load.php?debug=false&lang=fr&modules=site&only=scripts

A for loop is split where it is not legal:

for(var a=0,l=AllToggleLinks.length;a<l;a++){

becomes

for(var a=0,l=AllToggleLinks.length;a<l;a
++){

The remaining JavaScript is of course skipped, so many things do not work anymore.

Thanks and best regards,


Version: unspecified
Severity: critical

Details

Reference
bz28207

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:31 PM
bzimport set Reference to bz28207.
bzimport added a subscriber: Unknown Object (MLST).

I swear this got fixed on trunk, looking

(In reply to comment #1)

I swear this got fixed on trunk, looking

It was, r83934. Deployed to the live site, this should fix itself in 5-10
minutes.

Everything is back to normal.

Thanks a lot!

Best regards,