Page MenuHomePhabricator

action=paraminfo: Extract type from PARAM_DFLT if PARAM_TYPE is not set
Closed, ResolvedPublic

Description

Extract type from PARAM_DFLT if PARAM_TYPE is not set

The declaration

			'unwatch' => array(
				ApiBase::PARAM_DFLT => false,
				ApiBase::PARAM_DEPRECATED => true,
			),

gives in action=paraminfo no type= and a wrong default.

<param name="unwatch" description="Remove the page from your watchlist" deprecated="" default="" />

But the default of false indicate a boolean.

The attachment change this to:

<param name="unwatch" description="Remove the page from your watchlist" deprecated="" default="false" type="bool" />

Thanks.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz28254

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:33 PM
bzimport set Reference to bz28254.

Will look at this when I'm back on my desktop (later tonight or tomorrow)

r85758

Thanks for the patch! :)