Page MenuHomePhabricator

UploadWizard - final page incorrect thumbnail URL
Closed, ResolvedPublic

Description

Author: neilk

Description:
If thumbnailing fails on the final step, it is still possible to get the stashed thumbnail URL, even if the linked URL is to the real File: page.

<a href="http://test.wikipedia.org/wiki/File:Bar.png" target="_new"><img height="18" width="120" src="http://test.wikipedia.org/wiki/Special:UploadStash/thumb/trgsdd6y9s49zudy2xqaa6tysfp3orb.png/120px-trgsdd6y9s49zudy2xqaa6tysfp3orb.png"></a>

solution -- probably we should forget about all stashed thumbs at the moment of final upload


Version: unspecified
Severity: normal

Details

Reference
bz28325

Related Objects

StatusSubtypeAssignedTask
DeclinedNone
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:26 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz28325.
bzimport added a subscriber: Unknown Object (MLST).

neilk wrote:

Hard to understand how this can even occur. Proceeding to the final "thanks" page requires a successful result. So, this seems to be a manifestation of other "warnings" being ignored on Description submission (bug 24758). It is possible those don't return an imageinfo and then nothing else works.

neilk wrote:

Was hard to reproduce even before, and best guess is that this bug is fixed ever since the pubsub method of getting thumbnails was introduced. Cannot reproduce, even by using browsers which need remote scalers, and then turning off scaler halfway through upload process, or through entire process. User will get broken thumbnail, but final link will still be correct.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM