Page MenuHomePhabricator

Set forgotten parameters types in ApiParse
Closed, ResolvedPublic

Description

Please mark action=parse&oldid and &pageid as integer, because the pageid and the oldid in MediaWiki are always integers. The pageids and revids in ApiPageSet also marked as integer. Please change the type to integer, so action=paraminfo can output that correct.

Thanks.


Version: 1.18.x
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=28394

Details

Reference
bz28395

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:30 PM
bzimport set Reference to bz28395.

content hidden as private in Bugzilla

Created attachment 8373 [details]
Fix

Simple solution, not sure if there's more to it. Is there ?

Attached:

(In reply to comment #2)

Created attachment 8373 [details]
Fix

Simple solution, not sure if there's more to it. Is there ?

That's pretty much it. But I've been tied up doing craptastic coursework over the weekened, so didn't get round to fixing these simple bugs

Just RELEASE-NOTES when you commit

Attached:

(In reply to comment #4)

See also https://bugzilla.wikimedia.org/show_bug.cgi?id=28394.

Will do tonight, and include in RELEASE-NOTES.

Stop fixing my easy bugs! :P

(In reply to comment #3)

That's pretty much it.

Just RELEASE-NOTES when you commit

(In reply to comment #5)

Will do tonight, and include in RELEASE-NOTES.

Stop fixing my easy bugs! :P

You basically told me to do it! xD

'oldid' and 'pageid' has been set to 'integer' in r85376.