Page MenuHomePhabricator

Some small improvements for the mw.log() box
Closed, ResolvedPublic

Description

Author: a.d.bergi

Description:
proposed patch

The log box for console-less browsers doesn't show linebreaks, and it hides 150px at the bottom of the page.
I'm not sure who would try to debug mw javascript in a console-less browser, but this simple patch won't hurt :-)

For testing it you might have to type 'console.log=""' in your console before typing 'mw.log("test\n linebreak")'.


Version: 1.17.x
Severity: normal

Attached:

Details

Reference
bz28699

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:25 PM
bzimport set Reference to bz28699.

The pre-wrap seems to turn \n into nice line breaks (yay), but I don't think the fix for the hidden bits at the bottom works.

I still can't scroll down to the very bottom of the page in IE 8; the console window still blocks off.

(Unable to get the in-browser console to show on any of my other browsers, as they all have modern debug consoles in the system.)

a.d.bergi wrote:

IE 9 works for me, I can't test version 8.*.

For browsers with a console try javascript:void(console.log=""); before some javascript:void(mw.log("Hallo\n Welt"));

Works in other Internet Explorer versions as well - and has been tested in Vector, Monobook and Modern. I applied this in r87077.