Page MenuHomePhabricator

PHPUnit tests fail on Git checkouts
Closed, ResolvedPublic

Description

$ git clone http://github.com/mediawiki/mediawiki-trunk-phase3.git
$ php install.php --dbtype sqlite --dbname gittest --dbpath /home/maxsem --pass foo bar baz

maxsem@ci:~/mediawiki-trunk-phase3/tests/phpunit$ make destructive
php phpunit.php --configuration /home/maxsem/mediawiki-trunk-phase3/tests/phpunit/suite.xml
Unexpected non-MediaWiki exception encountered, of type "UnexpectedValueException"
exception 'UnexpectedValueException' with message 'RecursiveDirectoryIterator::construct(./skins): failed to open dir: No such file or directory' in /usr/share/php/PHPUnit/Runner/IncludePathTestCollector.php:124
Stack trace:
#0 /usr/share/php/PHPUnit/Runner/IncludePathTestCollector.php(124): RecursiveDirectoryIterator->
construct('./skins')
#1 /usr/share/php/PHPUnit/Util/Configuration.php(759): PHPUnit_Runner_IncludePathTestCollector->collectTests()
#2 /usr/share/php/PHPUnit/Util/Configuration.php(712): PHPUnit_Util_Configuration->getTestSuite(Object(DOMElement), false)
#3 /usr/share/php/PHPUnit/TextUI/Command.php(793): PHPUnit_Util_Configuration->getTestSuiteConfiguration(false)
#4 /usr/share/php/PHPUnit/TextUI/Command.php(155): PHPUnit_TextUI_Command->handleArguments(Array)
#5 /home/maxsem/mediawiki-trunk-phase3/tests/phpunit/MediaWikiPHPUnitCommand.php(20): PHPUnit_TextUI_Command->run(Array, true)
#6 /home/maxsem/mediawiki-trunk-phase3/tests/phpunit/phpunit.php(63): MediaWikiPHPUnitCommand::main()
#7 {main}
make: *** [phpunit] Error 1

Reproduceable on Windows, too.


Version: 1.20.x
Severity: normal

Details

Reference
bz28908

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:26 PM
bzimport set Reference to bz28908.
bzimport added a subscriber: Unknown Object (MLST).

Cannot reproduce on Ubuntu 11.04 with PHPUnit freshly updated via pear. SVN and git mirror checkouts appear to run identically.

However it's increeeedddiibbbbllllyyyyy slow, so it might be dying partway through if you're chopping out the output prior to that.

Output so far for SVN:

brion@stormcloud:~/pages/phase3/tests/phpunit$ make destructive
php phpunit.php --configuration /var/www/phase3/tests/phpunit/suite.xml
PHPUnit 3.5.13 by Sebastian Bergmann.

................................................IIIII........ 61 / 2270 ( 2%)
.......................I..................................... 122 / 2270 ( 5%)
..........................EEEEEEEE........................... 183 / 2270 ( 8%)
...

and git:

brion@stormcloud:~/pages/mediawiki-trunk-phase3/tests/phpunit$ make destructivephp phpunit.php --configuration /var/www/mediawiki-trunk-phase3/tests/phpunit/suite.xml
PHPUnit 3.5.13 by Sebastian Bergmann.

................................................IIIII........ 61 / 2270 ( 2%)
.......................I..................................... 122 / 2270 ( 5%)
..........................EEEEEEEE........................... 183 / 2270 ( 8%)
...

(In reply to comment #1)

Cannot reproduce on Ubuntu 11.04 with PHPUnit freshly updated via pear. SVN and
git mirror checkouts appear to run identically.

I tested on ci.tesla, the *test* server:)

However it's increeeedddiibbbbllllyyyyy slow

This is bug 27877.

so it might be dying partway

No, it explodes immediately.

Right, upgrading PHPUnit to 3.5+ fixed this both on ci.tesla and my box, so I made it a requirement in r87839.