Page MenuHomePhabricator

Remove all jquery/js files that already exist in core
Closed, ResolvedPublic

Description

UW is probably one of the worst "offenders" of this. Granted, some are needed to work with the older versions, but any that are in at least 1.17 should be cleaned up

Like the datepicker files, among many others :)


Version: unspecified
Severity: enhancement

Details

Reference
bz29099

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:26 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz29099.

r88610, r88611, r88612, r88613, r88614, r88615, r88616, r88617, r88618, r88621

Tipsy is in core, and has been for a while. I guess that's another candidate to strip from UW :). Not sure what the difference between version 1.0.0a and version 1.0.0a+ is. Maybe someone could tidy that up and remove from UW? Even if the UW version replaces the core one

Spinner can also go away with 1.19 (it's in phase3)

jquery.autocomplete could probably be pulled straight into core

ibaker wrote:

While we're at it, the JS wikitext parser is another good candidate for something to roll into core. It's in the jQueryMsg extension (though that version is a little out-of-date), but should really not be an extension at all.

(In reply to comment #3)

While we're at it, the JS wikitext parser is another good candidate for
something to roll into core. It's in the jQueryMsg extension (though that
version is a little out-of-date), but should really not be an extension at all.

{{BeBold}} && {{JFDI}} :D

Seems relatively simple and standalone

As long as files are svn copied in, all should be well

neilk wrote:

Yeah, also I want to use some libraries from UW in the VisualEditor thing so I'm moving quite a few of them out right now.

Reedy: svn copy and not svn move?

(In reply to comment #5)

Yeah, also I want to use some libraries from UW in the VisualEditor thing so
I'm moving quite a few of them out right now.

Reedy: svn copy and not svn move?

As per IRC, svn move is fine (as it's svn copy && svn delete)

(In reply to comment #3)

While we're at it, the JS wikitext parser is another good candidate for
something to roll into core. It's in the jQueryMsg extension (though that
version is a little out-of-date), but should really not be an extension at all.

See bug 32979, seems we have a core module dependent on extensions :(

Looks like this is in reasonable shape now..

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:20 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:20 AM