Page MenuHomePhabricator

Hide ArticleFeedback tool from print view
Closed, ResolvedPublic

Details

Reference
bz29156

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:31 PM
bzimport set Reference to bz29156.

This should be trivial with something like @media print { .blah { display: none; } }

[Mid-air collision detected!]

(In reply to comment #1)

This should be trivial with something like @media print { .blah { display:
none; } }

Or someone could add a line similar to that of r88151 to avoid the redirects. Specifically, the following should be sufficient:

&& mw.util.getParamValue( 'printable' ) != 'yes'

(In reply to comment #3)

[Mid-air collision detected!]

(In reply to comment #1)

This should be trivial with something like @media print { .blah { display:
none; } }

Or someone could add a line similar to that of r88151 to avoid the redirects.
Specifically, the following should be sufficient:

&& mw.util.getParamValue( 'printable' ) != 'yes'

no, that won't work for bookview and users who don't actually have to use the printable link (that would be anybody not using IE6) in order to get the printview when printing.

(In reply to comment #4)

no, that won't work for bookview and users who don't actually have to use the
printable link (that would be anybody not using IE6) in order to get the
printview when printing.

I'm not sure about what you mean by "bookview". Could you clarify?

PDF and pediapress parsing. Though since this is a JS tool, it probably won't matter for that tool. Still, print view does not require you to click "Printable version" that's just for IE6 users.

(In reply to comment #6)

PDF and pediapress parsing. Though since this is a JS tool, it probably won't
matter for that tool.

Ah, ok.

Still, print view does not require you to click
"Printable version" that's just for IE6 users.

o.o

Good to know!

Should be fixed in r89198, pending code review.