Page MenuHomePhabricator

Inconsistent user messages on too many failed logins with ConfirmEdit enabled for logins
Open, MediumPublic

Description

There is a slight inconsistency on user messages when trying to log in to often. If you fail several times you both get a captcha implying you should type the captcha _and_ a message saying you can't log in. ("You have made too many recent login attempts. Please wait before trying again.")


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=46965

Details

Reference
bz29191

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:33 PM
bzimport set Reference to bz29191.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 8596
Screenshot

Attached:

captcha_bug.png (586×870 px, 43 KB)

If you wait the requisite time, do you still have to fill out the captcha? If so, then the messaging is correct.

General issue seems to be that it still offers you the login form, but tells you not to use it yet. That doesn't have anything to do with ConfirmEdit -- that's part of MediaWiki's core login handling.

(In reply to comment #2)

If you wait the requisite time, do you still have to fill out the captcha? If
so, then the messaging is correct.

Mhm, haven't tested it that far... How long is that, btw?

General issue seems to be that it still offers you the login form, but tells
you not to use it yet. That doesn't have anything to do with ConfirmEdit --
that's part of MediaWiki's core login handling.

So ConfirmEdit decides whether to show a captcha or not according to what MW does? If that's the case, "Product" should be switched to MediaWiki.

When login is disabled, that has nothing to do with ConfirmEdit. That's something done by core.

(In reply to comment #2)

General issue seems to be that it still offers you the login form, but tells
you not to use it yet. That doesn't have anything to do with ConfirmEdit --
that's part of MediaWiki's core login handling.

But then neither of the captcha or login form should be shown, right? If the extension can allow a login when that message would be shown provided the captcha is filled out correctly, then it should also change the message or not allow it to be shown.

At least, that is what it sounds like Hoo man is saying. Let me know if I'm confused.

(In reply to comment #5)

But then neither of the captcha or login form should be shown, right? If the
extension can allow a login when that message would be shown provided the
captcha is filled out correctly, then it should also change the message or not
allow it to be shown.

At least, that is what it sounds like Hoo man is saying. Let me know if I'm
confused.

Exactly, either show ONLY the message which tells you can't login or ONLY show the login form and let the user login. But showing a not disabled form which doesn't work is confusing.

(In reply to comment #2)

If you wait the requisite time, do you still have to fill out the captcha? If
so, then the messaging is correct.

Brion's answer was not answered but is the whole point of this bug: I've just tested myself, if you wait some time then filling the CAPTCHA is not necessary, you only have to enter the correct password; so the message is wrong.
The CAPTCHA should indeed be hidden.

The problem has been made worse by the new UserLogin because the CAPTCHA is now on top, *above* the warning about waiting some time before trying again to fill the rest of the form.