Page MenuHomePhabricator
Create Task
Maniphest T4930

Edit history is based on timestamp while diff prev/next links are based on revision id
Closed, ResolvedPublic
Actions

Description

Author: hardy

Description:
I just edited [[St. Louis Park, Minnesota]]. The edit history shows this:

# (cur) (last)  20:47, 21 July 2005 Michael Hardy (→Education)

# (cur) (last) 20:46, 21 July 2005 Michael Hardy (attempting to fix a mangled link)

The ostensibly last edit is summarized by the word "Education", that being the
section heading. Clicking on "last" informs me that the edit consisted of changing

the [[U.S. Department of Education]]

to

[[the U.S. Department of Education]].

In reality, my summary for the last edit, NOT the one BEFORE that, said
"attempting to fix mangled link", and in fact in that edit I changed

[[the U.S. Department of Education]]

to

the [[U.S. Department of Education]].

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=42296

Details

Reference
bz2930
SubjectRepoBranchLines +/-
Have Title::get(Next|Previous)RevisionID sort by timestampmediawiki/coremaster+47 -31
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 8:42 PM
• bzimport added a project: MediaWiki-Page-diffs.
• bzimport set Reference to bz2930.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jul 21 2005, 8:53 PM
• bzimport added a comment.Jan 31 2006, 6:09 PM

simonell wrote:

Another aspect, in the diff-view
(http://en.wikipedia.org/w/index.php?title=St._Louis_Park%2C_Minnesota&diff=19325761&oldid=19282350):
Clicking on next edit doesnt show the Edit summarized with Education

• bzimport added a comment.Feb 2 2006, 2:34 PM

gangleri wrote:

Hallo!

Please see
http://en.wikipedia.org/w/index.php?title=St._Louis_Park%2C_Minnesota&action=history&limit=20&offset=20050730000001

(cur) (last) 21:54, 21 July 2005 Michael Hardy (Trying to force this thing to

reload despite an apparent software bug.)
http://en.wikipedia.org/w/index.php?title=St._Louis_Park%2C_Minnesota&oldid=19326248

(cur) (last) 21:47, 21 July 2005 Michael Hardy (→Education)

http://en.wikipedia.org/w/index.php?title=St._Louis_Park%2C_Minnesota&oldid=19325673
*oldid* is out of order

(cur) (last) 21:46, 21 July 2005 Michael Hardy (attempting to fix a mangled link)

http://en.wikipedia.org/w/index.php?title=St._Louis_Park%2C_Minnesota&oldid=19325761

(cur) (last) 06:35, 21 July 2005 C.e.worthington (Added Educational Information)

http://en.wikipedia.org/w/index.php?title=St._Louis_Park%2C_Minnesota&oldid=19282350

Marking
Bug 3630: Inconsistency between "Earliest" revision, action=history and
"Previous diff" / "Next diff" navigation
as a duplicate of this bug and changing summary
Please read bug 3630 comment 3

best regards reinhardt [[user:gangleri]]

• bzimport added a comment.Feb 2 2006, 2:35 PM

gangleri wrote:

*** Bug 3630 has been marked as a duplicate of this bug. ***

• bzimport added a comment.Feb 2 2006, 2:54 PM

gangleri wrote:

*note*
A multiple sort key is required here:
first "timespamp", then "pageid" / "page_id" (?)

marking
Bug 2880: Page history gets mixed up if entries were created the same minute
as a duplicate of this bug

best regards reinhardt [[user:gangleri]]

• bzimport added a comment.Feb 2 2006, 2:56 PM

gangleri wrote:

*** Bug 2880 has been marked as a duplicate of this bug. ***

• bzimport added a comment.Feb 3 2006, 1:19 PM

gangleri wrote:

(In reply to comment #4)

*note*
A multiple sort key is required here:
first "timespamp", then "pageid" / "page_id" (?)

The multiple sort criteria first "timestamp", then "pageid" / "page_id" (?) at
history/diff should be the same as at "Special:Contributions/foo" and
[[Special:Recentchanges]].

The links at Special:Contributions/foo are using diff=prev&oldid=<oldid_no>.
The links at Special:Recentchanges are using
curid=<curid_no>&diff=<diff_no>&oldid=<oldid_no>.
Both seems to be sorted by timestamp and <diff_no>.

best regards reinhardt [[user:gangleri]]

*note*
history/diff is not mentioned at
Bug 2468: The code that generates the namespace form for Special:Contributions,
Special:Allpages and Special:Recentchanges should be merged
but I think that sort criterias should be the same exept for Special:Allpages

• bzimport added a comment.Feb 9 2006, 2:14 AM

dbenbenn wrote:

*** Bug 4925 has been marked as a duplicate of this bug. ***

• bzimport added a comment.Feb 9 2006, 2:16 AM

dbenbenn wrote:

I have another example of the "Next diff", "Prev diff" links not working right. See
http://commons.wikimedia.org/w/index.php?title=Template:Description&diff=next&oldid=246447
That link is supposed to show the difference between revision 246447
and the chronologically next revision. Instead, it shows the difference between
246447 and the ''previous'' revision, 246448. Apparently the diff view assumes
that page ID numbers are in chronological order, when they really aren't.

• bzimport added a comment.Feb 9 2006, 7:05 AM

hirsch.heisseich wrote:

Same problem appears here also:
http://de.wikipedia.org/w/index.php?title=MediaWiki:Notargettext&diff=next&oldid=1399036

As you can see in the history, it's in the wrong order:
http://de.wikipedia.org/w/index.php?title=MediaWiki:Notargettext&action=history

• brion added a comment.Apr 25 2006, 1:51 AM
  • Bug 5702 has been marked as a duplicate of this bug. ***
• Purodha added a comment.Apr 25 2006, 5:14 AM

Probably the same problem appears here:
http://ksh.wikipedia.org/w/index.php?title=User_talk:Purodha&direction=next&oldid=6719
the "Newer revision→" links to:
http://ksh.wikipedia.org/w/index.php?title=User_talk:Purodha&direction=next&oldid=6720
, following the link does not display the next newer revision, but the most current as of today.

Reason being most likely the oldid's not being in date/time order.
Here, the revisions newer than oldid=6720 have been created before all the older versions up to and including
oldid=6720 were created via Special:Import. As of now, no newer revisions have been made since.

• bzimport added a comment.Apr 25 2006, 7:50 PM

gangleri wrote:

*** Bug 5291 has been marked as a duplicate of this bug. ***

• brion added a comment.Dec 22 2006, 6:03 PM
  • Bug 8355 has been marked as a duplicate of this bug. ***
• brion added a comment.Sep 11 2007, 2:55 PM
  • Bug 11286 has been marked as a duplicate of this bug. ***
• brion added a comment.Apr 26 2008, 11:31 PM
  • Bug 8062 has been marked as a duplicate of this bug. ***
• brion added a comment.Apr 26 2008, 11:31 PM
  • Bug 6551 has been marked as a duplicate of this bug. ***
• bzimport added a comment.May 29 2009, 3:31 AM

matthew.britton wrote:

Changing summary, confusing to say "the edit history is wrong" when sorting based on timestamp is the expected behaviour from a user's perspective, making the edit history 'correct' and diff links 'wrong'.

P.Copp added a comment.Dec 2 2009, 2:34 PM

*** Bug 21741 has been marked as a duplicate of this bug. ***

• bzimport added a comment.Jul 10 2011, 2:43 AM

EN.WP.ST47 wrote:

Per Gurch, the issue is not that the edit history is wrong, but that the timestamps are wrong. This isn't MediaWiki's fault, if anything it's either a WikiMedia server cluster bug or it's that we should be using something other than timestamps to sort edits. There be dragons, in my opinion, with using something other than timestamp to sort because then users get confused, and short of buying a few atomic clocks there's no way to improve timestamp accuracy, as I presume each cluster is NTPing together. Is there anything to be done on this bug or can it be closed?

HappyDog added a comment.Jul 10 2011, 6:40 PM

I don't think it's relevant whether the timestamps are right or wrong. There will be valid reasons where sorting by ID and by timestamp give different results (e.g. transwiki imports, or article merges). The problem is that the sorting is done by timestamps in one place (revision list), and IDs in another ('diff with previous' link).

All sorting of revisions should be done by timestamp, then ID, in all cases. This would remove inconsistencies within the various user interfaces where revisions are displayed/used.

Problems on the cluster that result in incorrect timestamps (if they exist) are a completely separate issue, and should be handled by a different bug.

Graham87 added a comment.Oct 29 2011, 9:23 AM

The effects of this bug have changed a bit since the MediaWiki 1.18 update. The "diff prev"/"diff next" links are still sorted by revision ID, but the number of intermediate revisions found above the diff is now calculated by date rather than revision ID. See sections 3 and 4 of:
http://en.wikipedia.org/wiki/User:Graham87/Page_history_observations#Strange_times_reported_in_diffs

Graham87 added a comment.Oct 29 2011, 9:24 AM

Oops, I meant:
http://en.wikipedia.org/wiki/User:Graham87/Page_history_observations

Aklapper added a comment.Nov 10 2012, 3:45 PM
  • Bug 2219 has been marked as a duplicate of this bug. ***
Aklapper added a comment.Nov 10 2012, 3:46 PM
  • Bug 1919 has been marked as a duplicate of this bug. ***
Aklapper added a comment.Nov 10 2012, 4:12 PM
  • Bug 6871 has been marked as a duplicate of this bug. ***
PleaseStand added a comment.Sep 27 2013, 5:36 AM
  • Bug 24671 has been marked as a duplicate of this bug. ***
He7d3r mentioned this in T91883: prop=revisions sorts by rev_id, not by rev_timestamp.Mar 17 2015, 5:14 PM
Anomie updated the task description. (Show Details)Apr 29 2015, 6:53 PM
Anomie set Security to None.
Anomie merged a task: T97543: rev_parent_id not used correctly with diff=prev or rvdiffto=prev for some revisions (Conversion script?).Apr 29 2015, 6:55 PM
Anomie added subscribers: Anomie, Halfak, Aklapper.
Ricordisamoa subscribed.Aug 18 2015, 6:32 AM
Beta16 mentioned this in T114756: Special:Contributions should sort by rev_id if two revisions have the same rev_timestamp.Oct 6 2015, 1:47 PM
Umherirrender mentioned this in T115975: Broken parent revisions on some old imported edits.Oct 20 2015, 5:03 PM
Meno25 unsubscribed.Feb 22 2016, 7:15 PM
gandaro subscribed.May 24 2016, 8:01 PM
gandaro added a comment.EditedMay 26 2016, 5:52 PM

The function that is incorrectly calculating the previous / next revision ID is DifferenceEngine::mapDiffPrevNext, which is called from DifferenceEngine::loadRevisionIds and Article::showDiffPage.

matmarex mentioned this in T163532: Drop index rev_page_id (rev_page, rev_id).Apr 21 2017, 9:04 PM
gerritbot subscribed.Apr 25 2017, 3:22 PM

Change 349501 had a related patch set uploaded (by Bartosz Dziewoński; owner: Anomie):
[mediawiki/core@master] Have Title::get(Next|Previous)RevisionID sort by timestamp

https://gerrit.wikimedia.org/r/349501

gerritbot added a project: Patch-For-Review.Apr 25 2017, 3:22 PM
matmarex subscribed.Apr 25 2017, 3:22 PM
WMDE-Fisch subscribed.May 5 2017, 8:59 AM
gerritbot added a comment.May 8 2017, 5:43 AM

Change 349501 merged by jenkins-bot:
[mediawiki/core@master] Have Title::get(Next|Previous)RevisionID sort by timestamp

https://gerrit.wikimedia.org/r/349501

matmarex closed this task as Resolved.May 8 2017, 11:04 AM
matmarex assigned this task to Anomie.
matmarex removed a project: Patch-For-Review.
Pppery merged a task: T4219: Incorrect revision dates on some revisions in various Wikimedia Foundation wikis.Apr 27 2019, 4:55 PM
Pppery added subscribers: • bzimport, Nemo_bis, • MZMcBride.
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM
Aklapper removed a subscriber: • wikibugs-l-list.
Aklapper removed subscribers: • bzimport, • Purodha, Anomie.Oct 16 2020, 5:43 PM
Aklapper mentioned this in T44296: page history shows unreviewed revisions, reverts in wrong order.Nov 7 2020, 5:18 PM
Aklapper mentioned this in T46841: Contributions appearing out of order.
Aklapper mentioned this in T48508: Non-unique value is used for paging on some pages.Nov 7 2020, 5:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL