Page MenuHomePhabricator

articlefeedback-pitch-thanks should be in singular form if the user submits only one rating
Closed, ResolvedPublic

Description

After a user rate an article according to only one (e.g. "Complete") of the four aspects (Trustworthy, Objective, Complete and Well-written) it is displayed the message:

"Thanks! Your ratings have been saved."

In this case, the message should not be in plural, since the user didn't touch in the ratings of the other aspects.


Version: unspecified
Severity: enhancement

Details

Reference
bz29323

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:29 PM
bzimport set Reference to bz29323.

Depends on having a ("not-too-heavy") javascript parser for wikitext in-core that is capable of plural. (unless we'd export multiple messages, but having {{PLURAL:$1|rating|ratings}} where $1 is the number of ratings submitted is better.

Setting priority to low.

(In reply to comment #1)

Depends on having a ("not-too-heavy") javascript parser for wikitext in-core
that is capable of plural. (unless we'd export multiple messages, but having
{{PLURAL:$1|rating|ratings}} where $1 is the number of ratings submitted is
better.

AFAIK Neil already has one of these and we just haven't integrated it yet.

(In reply to comment #2)

AFAIK Neil already has one of these and we just haven't integrated it yet.

Don't we now have it?

Change 78544 had a related patch set uploaded by Nemo bis:
articlefeedback-pitch-thanks should be in singular form if the user submits only one rating

https://gerrit.wikimedia.org/r/78544

Change 78544 merged by Siebrand:
articlefeedback-pitch-thanks should be in singular form if the user submits only one rating

https://gerrit.wikimedia.org/r/78544