Page MenuHomePhabricator

Date suggestion should extract time as well from EXIF data
Closed, ResolvedPublic

Description

The prefilled date should include time, as most Commons tools and forms already do, instead of stripping it: it's a valuable piece of information and quite tedious to copy from exif data (especially if you don't know the #metadata section; and most users don't), as well as quite difficult to remember.


Version: unspecified
Severity: minor
URL: http://commons.wikimedia.org/w/index.php?title=File:East_Side_Gallery,_Dmitri_Vrubel_%28in_2011%29.jpg&oldid=55624776

Details

Reference
bz29470

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:25 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz29470.
bzimport added a subscriber: Unknown Object (MLST).

The problem was reported on http://commons.wikimedia.org/w/index.php?title=Commons:Bar_italiano&oldid=55623936#Scusate_se_fosse_una_banalit.C3.A0. when you can see that it produced quite a lot of confusion (as the length of the message shows).

Can someone attach an example file with EXIF time/date data to this bug report? I have been unable to find anything helpful in search engines.

(In reply to comment #2)

Can someone attach an example file with EXIF time/date data to this bug report?
I have been unable to find anything helpful in search engines.

Try https://commons.wikimedia.org/wiki/Special:Random/File

I have this patch 99% finished. The last bit of it is some i18n work, because there needs to be proper representation of the date and time. So, I'm asking the i18n people what to do, since there doesn't appear to be an obvious solution. Stay tuned.

Note that the date selector on that field will overwrite the value, and does not include time, so if you mess with it, you'll lose the time value. I suppose that won't matter for people who just want to get the time from the image and carry on, but it's a potential speed bump.

All right, going crazy today, here's a patch for you: https://gerrit.wikimedia.org/r/9654

It doesn't do anything complicated for the date output, so i18n might need to take a look at it and figure something out. If I need to write up a better way, so be it.

(In reply to comment #5)

It doesn't do anything complicated for the date output, so i18n might need to
take a look at it and figure something out. If I need to write up a better way,
so be it.

What format are you using then? Commons wants 2012-06-12 9:14, although some string magic is applied to fix it anyway.

Thehelpfulonewiki wrote:

Reassigning to wikibugs-l per bug 37789

removed i18n, as it isn't related to i18n. removed patch and patch need review as this patch is in gerrit.

matanya, the date format was why I was concerned, I didn't know if there was a better way to localise the date for display. This could be a useful addition to the mediawiki default modules....maybe in my mw.Time. All right, fair enough, this is clearly something I should look at :)

But until I get mw.Time merged and patched to do this, is there another way?

Also, I've been using patch and patch-need-review to indicate that it's separate from non-patched bugs. Without that tag, people might visit this bug looking for something to do, and only discover the patch after (best case) reading five comments or (worst case) fixing the bug themselves. Is this wrong? Should I do it a better way?

(In reply to comment #9)

Should I do it a better way?

I don't know; I know that Sumana is doing it like you and that this is being discussed at https://www.mediawiki.org/wiki/Thread:Talk:Git/Workflow/Bugzilla
Unless the decision has been taken elsewhere in the meanwhile, matanya should probably stop mass-adding/removing the keywords before there's some codified rule for them, and discussion should continue there.

Oh sorry, should have commented here.

Chad was kind enough to add the patch-in-gerrit keyword, so that I'm not making arbitrary and ambiguous (and potentially confusing) keyword choices.

This change has been merged but I think it only displays the time in the datepicker now. it still inserts only the date into the field ?

(In reply to comment #6)

(In reply to comment #5)

It doesn't do anything complicated for the date output, so i18n might need to
take a look at it and figure something out. If I need to write up a better way,
so be it.

What format are you using then? Commons wants 2012-06-12 9:14, although some
string magic is applied to fix it anyway.

https://commons.wikimedia.org/wiki/Template:Information/doc confirms it and https://commons.wikimedia.org/wiki/Template:ISOdate has the technical details for rendering.

Is this not fixed yet?

I also observed that for a file the time-date was collected by the exif data, but only the date can be entered using the datepicker not the time.

Yes, looks fixed now, and the format seems correct too.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM