Page MenuHomePhabricator

Searchbox displays text in gray instead of black
Closed, ResolvedPublic

Description

I've noticed sometimes when I type something in the search box on Portuguese Wikisource[1] it displays the text in gray instead of black (as happens in other projects. But I didn't find any CSS rule on [[wikisource:pt:MediaWiki:Common.css]] which could be causing this change.

The only thing I found was on the following rule from /skins/vector/screen.css[2][3]:

div#simpleSearch input.placeholder {
color: #999999;

}

If I go to firebug and disable this specific rule, the black color is restored.

[1] E.g. on [[wikisource:pt:Special:Preferences]]:
https://secure.wikimedia.org/wikisource/pt/w/index.php?title=Special:Preferences&debug=1&uselang=en
[2]https://secure.wikimedia.org/wikisource/pt/w/load.php?debug=true&lang=pt-br&modules=skins!vector&only=styles&skin=vector
[3]http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/vector/screen.css?view=markup#l393


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=29801

Details

Reference
bz29516

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:29 PM
bzimport set Reference to bz29516.
bzimport added a subscriber: Unknown Object (MLST).

EN.WP.ST47 wrote:

Tested on 08-July-2011 against live Wikisource::PT at both main page and special:preferences, placeholder text in the search box is grey, typed text is black. Works for me!

Created attachment 8762
Screenshot of enws on secure server (placeholder black on FF 5).png

I just tested it on firefox 5 and got a black placeholder.

Attached:

Screenshot_of_enws_on_secure_server_(placeholder_black_on_FF_5).png (66×298 px, 3 KB)

(In reply to comment #1)

Tested on 08-July-2011 against live Wikisource::PT at both main page and
special:preferences, placeholder text in the search box is grey, typed text is
black. Works for me!

Reopening since I'm still able to reproduce this on Windows XP using either of these browsers:

  • IE 8.0.6001.18702
  • Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

PS: This may be related to the Bug 29801.

Created attachment 8932
Search box on Iceweasel 3.5.16

(In reply to comment #3)

(In reply to comment #1)

Tested on 08-July-2011 against live Wikisource::PT at both main page and
special:preferences, placeholder text in the search box is grey, typed text is
black. Works for me!

Reopening since I'm still able to reproduce this on Windows XP using either of
these browsers:

  • IE 8.0.6001.18702
  • Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.9.2.3) Gecko/20100401

Firefox/3.6.3

The problem also happens when I use Mozilla/5.0 (X11; U; Linux x86_64; pt-BR; rv:1.9.1.16) Gecko/20110701 Iceweasel/3.5.16 (like Firefox/3.5.16)

Attached:

Search_box_on_Iceweasel.png (525×581 px, 69 KB)

I noticed that although the first line below[1] is executed, the second one is not being executed when I start typing on the search box:


42 | .bind( 'focus drop keydown paste', function( e ) {

|      if ($input.hasClass('placeholder')) { 
----

[1] From jquery.placeholder.js:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.placeholder.js?revision=94389&view=markup#l38

(In reply to comment #4)

PS: This may be related to the Bug 29801.

I can confirm that after removing[1] this script from Portuguese Wikisource,
both this bug and bug 29801 disappeared.

[1]https://secure.wikimedia.org/wikisource/pt/w/index.php?diff=231041&oldid=229953