Page MenuHomePhabricator
Create Task
Maniphest T31609

The TT icon overlaps with the "select font" link when wgBetterDirectionality is enabled
Closed, ResolvedPublic
Actions

Description

Robin's wgBetterDirectionality improvement was enabled in translatewiki.net recently. It greatly improves the handling of right-to-left languages there.

There's a problem with WebFonts, however: When the user's interface languages in the preferences is an RTL language, for example Hebrew, the TT (TrueType) icon near the font selection link in the top menu overlaps with the link text.

It is currently implemented as a CSS background-image property and the position is 0 60%, where 0 probably means "top left"; for RTL languages this is wrong. Maybe it can become a simple img tag before the link.

Version: unspecified
Severity: normal

Details

Reference
bz29609

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:35 PM
• bzimport added projects: MediaWiki-extensions-WebFonts, I18n.
• bzimport set Reference to bz29609.
Amire80 created this task.Jun 27 2011, 2:03 PM
• santhosh added a comment.Jun 28 2011, 3:50 PM

Fixed in r90972

• brion added a comment.Jun 28 2011, 5:35 PM

Reopening; there are other regressions with r90972 (see CR comments: z-index issue at least)

SPQRobin added a comment.Jun 29 2011, 12:12 AM

Indeed, the search box overlaps the font selection link. It should probably be right-aligned (next to the user name), as in LTR (i.e. RTL should mirror LTR).

• santhosh added a comment.Jun 30 2011, 3:31 PM

z-index issue fixed in r91077

Added the page directionality condition in r91179 . I am using $('body').hasClass('rtl') for finding the page direction. ( '#p-personal ul' ).attr('dir') does not give the value if wgBetterDirectionality is disabled. Using the rtl class of body is consistent. Is there a better way to do this? Or is this fine?

SPQRobin added a comment.Jun 30 2011, 4:10 PM

It works correctly, as far as I can see.

(marked as resolved)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL