Page MenuHomePhabricator
Create Task
Maniphest T31712

Default user options in MessagesXx files have no effect
Closed, ResolvedPublic
Actions

Description

The settings in the default user options in MessagesXx.php files (where xx is the wiki content language), have no effect. The value is overridden by the values in DefaultSettings.php. When removing an option from DefaultSettings, it uses the value again from MessagesXx.php

This bug is present for quite some time, since the defaultUserOptionOverrides are almost only used for quickbar (used by some legacy skins) by RTL languages, which is a small userbase so it didn't get noticed.

(Interesting side-note: in the case of quickbar for RTL languages, this bug is being "corrected" by another bug: CSS for RTL languages is flipped, so where "left" is the default option, it's flipped to "right", so your preferences will say you have left, while it's right, which it should be, but because of MessagesXx options and not because the CSS it's flipped)

Version: 1.20.x
Severity: major

Details

Reference
bz29712

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:29 PM
• bzimport added projects: MediaWiki-Core-Preferences, I18n.
• bzimport set Reference to bz29712.
• bzimport added a subscriber: Unknown Object (MLST).
SPQRobin created this task.Jul 4 2011, 10:26 PM
SPQRobin added a comment.Jul 4 2011, 11:43 PM

I am going to remove this (broken) feature, because depending on wgLang for defaultUserOptionOverrides makes much more sense than wgContLang (as it currently is), but is not possible because wgLang depends on the preferences itself.

Secondly, the only three prefs set in MessagesXx files are:

  • 'underline' => 0 by languages written in scripts that are hard to read with underlines -> can be set in CSS
  • 'quickbar' => 2 by RTL languages, this can be done differently (in SkinLegacy->qbSetting(à for example)
  • 'editfont' => 'sans-serif' -> can be set in CSS
SPQRobin added a comment.Jul 5 2011, 1:27 AM

Done in r91432

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL