Page MenuHomePhabricator

Include sign-offs and follow-up changes in the general form submission (instead of 3 separate forms)
Closed, DeclinedPublic

Description

Currently, if I inspect the code of a revision and also want to make a comment about it, I will need to submit the page two times.

I think if the user post a comment and has marked one of the sign-offs this data should also be submited (saving one page load).


Version: unspecified
Severity: normal

Details

Reference
bz29725

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:30 PM
bzimport set Reference to bz29725.
bzimport added a subscriber: Unknown Object (MLST).

Nice catch, I've been wondering about that.

PS: See also bug 29466 comment 3.

Part of it is because the pager sucks, and it was a PITA with the nested forms and other wierdness

I did try and fix this before

See also bug 26337

I actually originally wanted all the CR forms to commit changes immediately via AJAX but never got round to doing the ajax submissions or updates. ;)

For now, I agree it's probably best to make sure those subforms are integrated into the whole form which operates on a 'change a bunch of stuff and commit when done' model.