Page MenuHomePhabricator

Postgres-based searching breaks between 1.13.1 and 1.17.0
Closed, ResolvedPublic

Description

Author: andy

Description:
I upgraded MW from 1.13.1 to 1.17.0, and the search summaries on my intranet wiki broke, manifested by errors in the Apache log like this:

PHP Warning: pg_fetch_result(): supplied argument is not a valid PostgreSQL result resource in /var/www/html/bogey/mediawiki-1.17.0/includes/search/SearchPostgres.php on line 156

Turns out that when diffing 1.13.1's includes/SearchPostgres.php with 1.17.0's include/search/SearchPostgres.php, we see that line 151 in the 1.17.0 version

$res = $this->db->query($SQL);

was originally, in 1.13.1

$res = $this->db->doQuery($SQL);

When I change this line back to the 1.13.1 version, calling doQuery() instead of query(), everything works once again.


Version: 1.17.x
Severity: normal

Details

Reference
bz29761

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:32 PM
bzimport set Reference to bz29761.
bzimport added a subscriber: Unknown Object (MLST).

The change for this, seems to have been past 1.17 for 1.18, but not obviously backported

Change was in r81499

Will ping hexmode