Page MenuHomePhabricator

LQT shouldn't accept duplicated posts on the same page/thread
Open, LowestPublic

Description

I don't know if this was already reported but the extension shouldn't let users to (accidentally) submit duplicated posts (something which is common when the internet connection is slow), such as this
http://www.mediawiki.org/wiki/Thread:Talk:Article_feedback/Delete/reply_(18)


URL: http://www.mediawiki.org/wiki/Thread:Talk:Article_feedback/Delete/reply_(18)

Details

Reference
bz29786

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:34 PM
bzimport set Reference to bz29786.
bzimport added a subscriber: Unknown Object (MLST).

This is still happening. E.g.: [[mw:Thread:Talk:MoodBar/Ideas log (2)]].

I don't think this can happen without clicking the reply button twice, or can it?

(In reply to comment #2)

I don't think this can happen without clicking the reply button twice, or can
it?

Yep, but for users with slow connections, it is very common to see that spinner image running forever (see Bug 26290), meaning that the content was not sent yet. In those cases the only option the user have if he wants to post his reply is to send it again (without knowing if the first try was successfully submited). And this cause the duplicated threads. This is very common:

http://www.mediawiki.org/w/index.php?title=Special%3ALog&type=delete&user=&page=Thread%3ATalk%3AArticle+feedback%2FIrrelevant%2Freply+%2834%29&year=&month=-1&tagfilter=

http://www.mediawiki.org/w/index.php?title=Special%3ALog&type=delete&user=&page=Thread%3AProject%3ASupport+desk%2FI+can%27t+create+new+items+in+Mediawiki+%282%29&year=&month=-1&tagfilter=

http://www.mediawiki.org/w/index.php?title=Special%3ALog&type=delete&user=&page=Thread%3AProject%3ASupport+desk%2FHow+powerful+is+MediaWiki+for+the+following+listed+uses...%3F&year=&month=-1&tagfilter=

shealen.clare wrote:

This bug has not been touched in at least six months. With this in mind, I've been asked by the bugmeister to bump this bug's priority down for "High". Concerns can be addressed to mah@everybody.org.

Also, there is some indication above that the bug is a duplicate. Has this possibility been ruled out?

(In reply to comment #4)

Also, there is some indication above that the bug is a duplicate. Has this
possibility been ruled out?

Duplicate of which bug?

shealen.clare wrote:

(In reply to comment #5)

(In reply to comment #4)

Also, there is some indication above that the bug is a duplicate. Has this
possibility been ruled out?

Duplicate of which bug?

I'm making reference to the following quote in the bug description:

"I don't know if this was already reported but..."

Ah, ok.

Looking at
https://bugzilla.wikimedia.org/buglist.cgi?component=LiquidThreads&list_id=112920
I see the following bugs which may be related:

  • Bug 30222 - LiquidThreads creates thread duplicates when used with WikEd
  • Bug 19145 - Reduce duplicate LQT posts caused by re-submitting the same form

Maybe Bug 19145 should be REOPENED (since r52454 didn't fix the problem) and this bug and bug 30222 be marked as duplicated of that?

  • Bug 26705 has been marked as a duplicate of this bug. ***

Ping. This is still happening relatively often.

MariaDB [mediawikiwiki_p]> SELECT COUNT(*) AS DUPES FROM logging WHERE log_type = 'delete' AND log_namespace = 90 AND log_comment LIKE 'du%';
+-------+
| DUPES |
+-------+
|    71 |
+-------+
1 row in set (0.12 sec)

MariaDB [mediawikiwiki_p]> SELECT COUNT(*) AS DUPES FROM logging WHERE log_type = 'delete' AND log_namespace = 90 AND log_comment LIKE 'Du%';
+-------+
| DUPES |
+-------+
|    20 |
+-------+
1 row in set (0.11 sec)

Change 123836 had a related patch set uploaded by Adi.iiita:
LQT should not accept duplicate post

https://gerrit.wikimedia.org/r/123836

Change 123836 abandoned by Krinkle:
LQT should not accept duplicate post

https://gerrit.wikimedia.org/r/123836

Jdforrester-WMF lowered the priority of this task from Low to Lowest.Aug 4 2016, 11:34 PM
Jdforrester-WMF subscribed.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.