Discovered on wikitech, when the server hostname is configured with a relative protocol, the mails sent are broken.
It should either default to a configuration variable, a user preference or whatever the request triggering the mail had as protocol.
The problem with the latter is that it results in inconsistent e-mail (ie. user John get's mixed urls in his emails, some http some https one of which he is mostly likely not logged in at)
Version: unspecified
Severity: normal
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Make image work with BotPassword auth for officewiki | toolforge-repos/officewikibot-pywikibot!1 | bd808 | work/bd808/botpassword | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T21270 Relative URIs in interwiki links table break interwiki transclusion | |||
| Resolved | None | T20664 Relative URIs in interwiki links table causes failed redirects | |||
| Resolved | None | T22342 Support for protocol-relative URLs | |||
| Resolved | None | T31993 E-mail notification should work with protocol relative urls |
(In reply to comment #1)
This should be fixed with r93891, but I didn't test that. Can someone confirm?
Deployed the fix, and confirmed it on testwiki by asking Ryan to edit my talk page.
Turns out to be only semi-fixed. The primary URL is fixed now, but the footer reads:
To change your email notification settings, visit
//test.wikipedia.org/wiki/Special:Preferences
To change your watchlist settings, visit
//test.wikipedia.org/wiki/Special:Watchlist/edit
To delete the page from your watchlist, visit
http://test.wikipedia.org/w/index.php?title=User_talk:Catrope&action=unwatch
Feedback and further assistance:
//test.wikipedia.org/wiki/Help:Contents
(In reply to comment #4)
Turns out to be only semi-fixed. The primary URL is fixed now, but the footer
reads:
To change your email notification settings, visit
//test.wikipedia.org/wiki/Special:Preferences
Those were particularly nasty, because the i18n message looked like this:
To change your email notification settings, visit
{{fullurl:{{#special:Preferences}}}}
Fixed in a somewhat elaborate way, as part of a reorganization that needed to be done anyway, in r94995.