Page MenuHomePhabricator
Create Task
Maniphest T32041

"You have entered an invalid IP address for Memcached: localhost."
Closed, ResolvedPublic
Actions

Description

When setting up a new wiki on trunk (as of r93014), I put in for the Memcached config option "localhost:11211" to use my local memcached instance.

On submission, I got kicked back to the top of the same form with this error:

"You have entered an invalid IP address for Memcached: localhost."

In addition, some glitches in the page state:

  • lost selections from the extension checkboxes
  • caching subform shows off, instead of memcached which I last left it at. (reselecting it shows the localhost:11211 line I had put in before, so the data's still there)

Changing it to "127.0.0.1:11211" resolves this for me, but it sounds like the installer is trying to validate the host portion of memcached lines as raw IP addresses *only*. It's perfectly legit to use hostnames here.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=25855

Details

Reference
bz30041

Event Timeline

• bzimport raised the priority of this task from to High.Nov 21 2014, 11:50 PM
• bzimport added a project: MediaWiki-Installer.
• bzimport set Reference to bz30041.
• brion created this task.Jul 24 2011, 9:37 PM
• brion added a comment.Sep 21 2011, 11:57 PM

Bug introduced in r82687 for bug 25855.

Switching it to try resolving a hostname should be easy -- on it :D

• brion added a comment.Sep 22 2011, 12:12 AM

r97772 adds a gethostbyname() check if there is something but it's not an IP address; it now passes through 'localhost:11211' and anything else in your DNS or hosts, but will still reject things that can't be resolved to protect against misspells.

The memcached selection is still missing on the next page load...

• brion added a comment.Sep 22 2011, 12:37 AM

r97774 fixes the radio button initial value when coming back to the page via validation check or 'back', and makes sure that the memcached server textarea fold-out is initially shown if memcached is selected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL