Page MenuHomePhabricator

Help desk link uses user-interface language
Closed, ResolvedPublic

Description

Author: chrisipk

Description:
The help desk link on the start page of the upload wizard uses the user-language localized version of MediaWiki:Mwe-upwiz-help-desk-url. This means, every language points to a different page. For obvious reasons, this is not a good idea.

I propose the following behaviour:

  • MediaWiki:Mwe-upwiz-help-desk-url contains the project-language localized message.
  • The link on the upload wizard start page checks for a _local_ version of a user-language localized version of MediaWiki:Mwe-upwiz-help-desk-url. If one is found, use that one. If no local user-language localization can be found, use the non-localized MediaWiki:Mwe-upwiz-help-desk-url message (and not the default user-language localized version).

Example: Project has language setting en, user A has language setting es, user B has language setting fr. MediaWiki:Mwe-upwiz-help-desk-url/es exists.

User A will see the local content of MediaWiki:Mwe-upwiz-help-desk-url/es as a link to the help desk.

User B will see the content of MediaWiki:Mwe-upwiz-help-desk-url as a link to the help desk. As that message does not exist, it defaults to the localized message of MediaWiki:Mwe-upwiz-help-desk-url/en.


Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:50 PM
bzimport added projects: UploadWizard, I18n.
bzimport set Reference to bz30049.
bzimport added a subscriber: Unknown Object (MLST).

I don't know if this was once actually a problem, but this is actually what happens now, so I'm going to call this "fixed". Cheers!

Sorry! I tested with a non-existent language, but didn't try with a language that exists, but has no help desk.

Shouldn't this be a translation issue? If no page exists, don't translate the string and let it fall back to the English value?

Is this bug about http://commons.wikimedia.org/wiki/Special:UploadWizard?
Could you list a few languages to try this out with? uselang=hi didn't work well for me

Unfortunately closing this report as no further information has been provided.

ChrisiPK: Please feel free to reopen this report if you can provide the information asked for in comment 2 and comment 3, and if this still happens. Thanks!

chrisipk wrote:

Screenshot where the broken link occurs

First of all, sorry for not responding in a timely manner. I must admit I simply forgot about this bug and just saw it pop up today.

Actually, the problem is not resolved. Please see the attached screenshot where the broken link occurs.

As you can see, this link goes to a page in Hindi as specified in MediaWiki:Mwe-upwiz-help-desk-url/hi which does not exist locally on Commons. This is not very useful because this page does not exist on Commons.

Please let me know whether this clarifies things or what additional input you need.

Thanks!

Attached:

helpdesk-wrong-link.png (515×1 px, 94 KB)

Change 256741 had a related patch set uploaded (by MarkTraceur):
Fallback to English help desk

https://gerrit.wikimedia.org/r/256741

matmarex assigned this task to MarkTraceur.
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
matmarex removed a subscriber: wikibugs-l-list.

Change 256741 merged by jenkins-bot:
Fallback to English help desk

https://gerrit.wikimedia.org/r/256741