Page MenuHomePhabricator

Uploading more files causes ownwork license to be concatenated again ("self|self|self|"...)
Closed, ResolvedPublic

Description

Author: neilk

Description:
User:Ammodramus writes:

:::Have experimented further. The problem seems to be associated with the use of the "Upload more files" button on the bottom of the last page of the upload wizard sequence. Each time I click it and upload a new batch, it adds another "self|" to the license; thus the first batch of files came through OK, with <nowiki>"{{self|cc-zero}}"</nowiki>; the second batch had an error, with <nowiki>"{{self|self|cc-zero}}"</nowiki>; the third had <nowiki>"{{self|self|self|cc-zero}}"</nowiki>, etc.

:::After several iterations of this, I clicked the "Upload file" link in the left-margin menu, checked "Skip this step in the future" on the bottom of the first page, and uploaded another batch. The license came through fine; when I again clicked "Upload file" in the left margin, and uploaded yet another batch, there were no problems with the license.


Version: unspecified
Severity: major

Details

Reference
bz30237

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:53 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz30237.
bzimport added a subscriber: Unknown Object (MLST).

Elevating importance and severity.

neilk wrote:

Seems to be isolated to *only* cc-zero when combined with own-work, which in the current default config is "own-pd". The config is an edge-case, it's the only self license whose templates are specified as not the same as the original name. Not sure why this is so.

Is definitely not related to any misconfig on Commons since I can reproduce it on a wiki without any templates configured.

neilk wrote:

fixed in r97593.

In the case of cc-zero, we used a feature where the template name(s) can be different from the string describing them. But I forgot to obtain a copy of the config, and instead was pointing to the real config. So when "self" was prepended, that changed the config too.

It was only noticeable if you picked cc-zero and used the Upload more files button.

Fixed by obtaining a copy of the config to modify, rather than pointing to the original.

neilk wrote:

*** Bug 29346 has been marked as a duplicate of this bug. ***

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:19 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:20 AM