kazink wrote:

Quick and dirty fis for the Record index problem

Attached:

kazink wrote:

I found out where the problem is. The function loadContent() (includes/storage/SMW_QueryResult.php) has this comment near the 'index' processing code:

Print one component of a multi-valued string.
Known limitation: the printrequest still is of type _rec, so if printers check
// for this then they will not recognize that it returns some more concrete type.

It seems that the further processing does not recognize that this is a single value of a record, and tries to process it as a full record (which it isn't any more, because the single value has been extracted by the loadContent() function). This results in no value at all.

I attached a quick patch to work this problem around. Please note however, that this patch is only a workaround, NOT A SOLUTION. I suppose it may be utterly wrong when considered from the SMW architecture's point of view (I don't know SMW's code so much to provide a complete solution). And it simply may introduce other bugs, that I did not tested. It works as a quick and dirty fix - just to restore the normal functionality of my wiki, until the official fix is provided.

Markus, can you take on this one?

kazink wrote:

content hidden as private in Bugzilla

sumanah wrote:

Adding "patch" and "need-review" keywords to indicate patch awaits review.

Thanks, Kazimierz, for your analysis and suggestions. I have fixed the issue in r111267 and r111268. You were mostly right about the cause of the problem, but the main issue was in method getNextDataValue() where the (type record) property was used to create a datavalue object for the selected record field. The code there now finds and uses the correct property for each subvalue, even though this is not very efficient.

The comment about the "Known limitation" is in fact not relevant here. This limiation was always the same and only affects certain result printers (like timeline) that check the type of a printrequest to find out if a value can be used for a special purpose (in the case of timeline, a date-typed record field would not be accepted as a time to display, because the type says record). But this has always been the same.