Page MenuHomePhabricator

When upgrading: after the "upgrade complete" step, link text "You can now start using your wiki" and button text "Regenerate LocalSettings.php" are incorrect
Closed, DeclinedPublic

Description

While upgrading an existing database with a fresh checkout from SVN [1], I found a reproducible UI problem after the step "upgrade existing installation".

After the "upgrade complete" message, the box shows a link with the text

a) "You can now start using your wiki" ; and
b) button text "Regenerate LocalSettings.php"

When you follow the link a), you somehow break the installation in between and restart the installer index.php ("LocalSettings not found, complete the installation"). It is possible to continue the installation, but difficult.

Suggestion package:

Remove that link a) ; and
Change the text on the button b) to "Continue the installation. A new LocalSettings.php will be created."

[1] I mean: after a fresh checkout, when accessing the wiki, the installer starts. The former LocalSettings.php is in a backup place. There is no LocalSettings.php to be regenerated after a fresh checkout or download.


Version: 1.20.x
Severity: normal
Whiteboard: aklapper-moreinfo

Details

Reference
bz30298

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:58 PM
bzimport set Reference to bz30298.
bzimport added a subscriber: Unknown Object (MLST).

The related string in 1.22 git mentions that "This is '''not recommended''' unless you are having problems with your wiki.".

T.Gries: Is this sufficient?

Dropping the strings here:

'config-regenerate' => 'Regenerate LocalSettings.php →'
'config-upgrade-done' => "Upgrade complete.

You can now [$1 start using your wiki].

If you want to regenerate your <code>LocalSettings.php</code> file, click the button below.
This is '''not recommended''' unless you are having problems with your wiki.",

@André:

thanks for pinging me. Must think about it. Long time ago...

No reply - assuming the new string is acceptable.
If not, please reopen this ticket.