Page MenuHomePhabricator
Create Task
Maniphest T32359

wgMaxRedirects > 1 not working as intended (redirects not updated after move?)
Closed, DeclinedPublic
Actions

Description

After a page move all redirects which a linking to the moved page have to be updated to the new target.

The problem is only visible with $wgMaxRedirects > 1, because than there a working redirects pointing to the page which are not updated after move and so the redirection is not working proper.

The update of the redirect table is missing.

Thanks.

Steps to reproduce:

  • set $wgMaxRedirects = 2;
  • create page A with text
  • move page A to page B with a redirect
  • move page B to page C with a redirect
  • visited page A, you get redirect to page B, not to page C
  • create page A2 with a redirect to page B (copy the wikitext from page A)
  • visited page A2, you get redirect to page C

Version: 1.20.x
Severity: normal

Details

Reference
bz30359
TitleReferenceAuthorSource BranchDest Branch
Remove links to 'point in time' topics using a denylist of qids.repos/structured-data/section-topics!15xcollazoT323597-exclude-dates-take-2main
Customize query in GitLab

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:51 PM
• bzimport added a project: MediaWiki-Redirects.
• bzimport set Reference to bz30359.
• bzimport added a subscriber: Unknown Object (MLST).
Umherirrender created this task.Aug 13 2011, 9:04 AM
Catrope added a comment.Aug 13 2011, 11:45 AM

This is one of the reasons why I thought allowing multiple redirects was a bad idea.

However, we should NOT update the redirect table such that A->C, because that will break things if B is edited to be a redirect to D. Instead, the redirect table should continue saying A->B and B->C, and the redirect resolution code should follow both redirects rather than stopping after the first one.

Bawolff added a comment.Mar 4 2012, 3:16 AM
  • Bug 33520 has been marked as a duplicate of this bug. ***
Markhurd subscribed.Feb 19 2015, 1:58 AM
Paine_Ellsworth subscribed.May 31 2015, 11:10 AM
Paine_Ellsworth added a comment.Jul 2 2015, 6:04 PM

Was wondering - when double redirects are allowed, will there also be "triple redirects", "quadruple redirects" and so on? And will they also be allowed and functional?

• MZMcBride subscribed.Jul 2 2015, 6:05 PM
petr.matas subscribed.Jan 2 2016, 3:19 PM
In T32359#1421924, @Paine_Ellsworth wrote:

Was wondering - when double redirects are allowed, will there also be "triple redirects", "quadruple redirects" and so on? And will they also be allowed and functional?

It depends just on the $wgMaxRedirects setting for the given wikisite. If it is set to 4, then a chain A->B->C->D->E will be transparent to the reader, but upon visiting A for the chain A->B->C->D->E->F you will see

E

(Redirected from A)
→F

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2016, 3:19 PM
Mdann52 added a project: Wikimedia-Site-requests.Jan 3 2016, 7:27 PM
Mdann52 subscribed.
Restricted Application added subscribers: JEumerus, Matanya. · View Herald TranscriptJan 3 2016, 7:27 PM
Mdann52 claimed this task.Jan 3 2016, 7:27 PM
Mdann52 closed this task as a duplicate of T67064: Increase $wgMaxRedirects on enwiki.
JEumerus unsubscribed.Jan 3 2016, 7:39 PM
Catrope unsubscribed.Jan 15 2016, 10:57 PM
petr.matas reopened this task as Open.Feb 8 2016, 6:11 PM
petr.matas added a subtask: T122771: $wgMaxRedirects does not appear to work as intended.
petr.matas set Security to None.
petr.matas added a comment.Feb 8 2016, 6:17 PM

This task cannot be a duplicate of T67064, because the bug described here is not mentioned there.

JEumerus subscribed.Feb 8 2016, 6:18 PM
petr.matas mentioned this in T122771: $wgMaxRedirects does not appear to work as intended.Feb 8 2016, 7:34 PM
Jack_who_built_the_house subscribed.Nov 17 2016, 6:50 PM
Krinkle renamed this task from redirects to a page not updated after move to wgMaxRedirects > 1 not working as intended (redirects not updated after move?).Apr 30 2017, 3:17 AM
Krinkle removed a subtask: T122771: $wgMaxRedirects does not appear to work as intended.
Krinkle merged a task: T122771: $wgMaxRedirects does not appear to work as intended.
Krinkle removed a project: Wikimedia-Site-requests.
Krinkle added subscribers: Se4598, Fomafix, Luke081515.
Krinkle removed a subscriber: • wikibugs-l-list.
Luke081515 removed Mdann52 as the assignee of this task.Apr 30 2017, 12:45 PM

I guess this claim at T32359#1913500 was unexpected, if not, feel free to revert.

Krinkle moved this task from General to Database on the MediaWiki-Redirects board.Jul 31 2017, 9:25 PM
Ahecht awarded a token.Oct 11 2017, 6:42 PM
Ahecht subscribed.
DannyS712 subscribed.Feb 6 2019, 3:20 AM
daniel mentioned this in T296430: Remove support for $wgMaxRedirects.Nov 24 2021, 7:40 PM
daniel closed this task as Declined.EditedNov 24 2021, 7:50 PM
daniel subscribed.

Probably best to just kill the feature, see T296430. Implementing it properly would need quite a bit of effort.

Krinkle mentioned this in T65388: set $wgMaxRedirects = 2 on dewiki.Apr 9 2022, 2:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL