Page MenuHomePhabricator
Create Task
Maniphest T32393

Please give a special warning when people try to use complex numbers in {{#expr:}}
Closed, DeclinedPublic
Actions

Description

Author: theevilipaddress

Description:
I have recently tried to work with the variable "i", i.e. complex numbers in the {{#expr:}} parser function. Of course, this didn't work and gave the error: Expression error: Unrecognised word "i".

However, I was wondering if in case of "i", a more specific error could be thrown, e.g. "MediaWiki does not natively support the calculation of complex numbers.", because I had wondered for some time if I made something wrong.

Version: unspecified
Severity: enhancement

Details

Reference
bz30393
SubjectRepoBranchLines +/-
Fix give errors on using complex number in {{#expr:}}mediawiki/extensions/ParserFunctionsmaster+11 -3
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
kubernetes.py: Ensure log messages aren't too largerepos/releng/scap!55dancyreview/dancy/split-big-log-messagesmaster
Send image build/deploy transcripts to syslogrepos/releng/scap!51dancyreview/dancy/T323939-k8s-build-transcriptsmaster
Customize query in GitLab

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:53 PM
• bzimport added a project: ParserFunctions.
• bzimport set Reference to bz30393.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Aug 16 2011, 10:13 AM
Rammanojpotla subscribed.Jan 23 2018, 11:05 AM

can you specify the list of all complex words do that they could be given that specific error?

Rammanojpotla added a comment.Jan 23 2018, 11:08 AM

if this change is to be solved then almost all the .json files in i18n directory have to be added with such specific error what about the languages other than English how could the manipulation in them be done in their own language?

Rammanojpotla added a comment.Jan 27 2018, 6:21 PM

on adding a special kind of warning, the patch at https://gerrit.wikimedia.org/r/#/c/406391/ Jenkins gives a failure due to failure at mwgate-npm-node-6-docker it is given that it has to be documented but where should the warning be documented?

Rammanojpotla added a project: Patch-For-Review.Jan 28 2018, 3:08 AM

a related patch is posted at https://gerrit.wikimedia.org/r/#/c/406391/4

gerritbot subscribed.Jan 28 2018, 8:44 PM

Change 406391 had a related patch set uploaded (by Zoranzoki21; owner: Rammanoj):
[mediawiki/extensions/ParserFunctions@master] Fix give errors on using complex number in {{#expr:}}

https://gerrit.wikimedia.org/r/406391

gerritbot added a comment.Jan 30 2018, 6:22 PM

Change 406391 had a related patch set uploaded (by Zoranzoki21; owner: Rammanoj):
[mediawiki/extensions/ParserFunctions@master] Fix give errors on using complex number in {{#expr:}}

https://gerrit.wikimedia.org/r/406391

thiemowmde closed this task as Declined.Jun 12 2018, 5:58 PM
thiemowmde subscribed.

I believe an extension that does not support complex numbers should not have special error handling code for complex numbers. If an expression contains an unrecognised word, the error message already says so.

gerritbot added a comment.Jun 12 2018, 5:59 PM

Change 406391 abandoned by Thiemo Kreuz (WMDE):
Fix give errors on using complex number in {{#expr:}}

Reason:
See T32393, as well as what I wrote before.

https://gerrit.wikimedia.org/r/406391

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL