Page MenuHomePhabricator

Unclickable URLs in IRC feed when using protocol relative URLs
Closed, ResolvedPublic

Description

When using protocol relative URLs, the links in IRC are also protocol relative and not clickable.

See for example #betawiki-rc on Freenode IRC. Example line:


[[MediaWiki:Code-browsing-path/zh-hans]] //translatewiki.net/w/i.php?diff=3182911&oldid=2131330 * Username * (+0)


Relevant code is near line 700 in includes/RecentChange.php: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/RecentChange.php?view=annotate


Version: unspecified
Severity: normal

Details

Reference
bz30398

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:54 PM
bzimport set Reference to bz30398.

Fixed in r94754 and deployed to the Wikimedia cluster. This bug was also affecting the IRC feeds for testwiki and wikimania2005wiki.

Now showing clickable URLs. Thanks!

I see that the URLs are now http (only?). Is it possible to make them https, too?

(In reply to comment #2)

Now showing clickable URLs. Thanks!

I see that the URLs are now http (only?). Is it possible to make them https,
too?

Hashar mentioned a similar thing on CodeReview: what if the wiki only supports HTTPS?

I'll add a config option later that allows you to specify whether you want to use HTTP or HTTPS here.

(In reply to comment #3)

(In reply to comment #2)

Now showing clickable URLs. Thanks!

I see that the URLs are now http (only?). Is it possible to make them https,
too?

Hashar mentioned a similar thing on CodeReview: what if the wiki only supports
HTTPS?

I'll add a config option later that allows you to specify whether you want to
use HTTP or HTTPS here.

Seems to be done by r94995. Reminder.

(In reply to comment #4)

Seems to be done by r94995. Reminder.

Yes, r94995 had this effect by introducing $wgCanonicalServer