Page MenuHomePhabricator

LocalisationUpdate fails for empty message files
Closed, DeclinedPublic

Description

When a message file is empty (e.g. when deliberately adding an empty file to make LocalisationUpdate add that language), it fails.

I tried adding an empty $messages = array(); but even that gives a warning. Then I get:


PHP Warning: array_merge(): Argument #1 is not an array in C:\wamp\www\mw\exten
sions\LocalisationUpdate\LocalisationUpdate.class.php on line 367
PHP Stack trace:
PHP 1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate\update.php:0
PHP 2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\extensions\Localisa
tionUpdate\update.php:32
PHP 3. LocalisationUpdate::updateMediawikiMessages() C:\wamp\www\mw\extensions
\LocalisationUpdate\LocalisationUpdate.class.php:58
PHP 4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\extensions\Localisati
onUpdate\LocalisationUpdate.class.php:175
PHP 5. array_merge() C:\wamp\www\mw\extensions\LocalisationUpdate\Localisation
Update.class.php:367

Warning: array_merge(): Argument #1 is not an array in C:\wamp\www\mw\extensions
\LocalisationUpdate\LocalisationUpdate.class.php on line 367

Call Stack:

0.0019     642296   1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate

\update.php:0

0.2241   16614104   2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\e

xtensions\LocalisationUpdate\update.php:32

0.2241   16614344   3. LocalisationUpdate::updateMediawikiMessages() C:\wamp

\www\mw\extensions\LocalisationUpdate\LocalisationUpdate.class.php:58

53.3661   17563600   4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\ext

ensions\LocalisationUpdate\LocalisationUpdate.class.php:175

54.2947   17796048   5. array_merge() C:\wamp\www\mw\extensions\LocalisationU

pdate\LocalisationUpdate.class.php:367

PHP Warning: array_diff_assoc(): Argument #2 is not an array in C:\wamp\www\mw\
extensions\LocalisationUpdate\LocalisationUpdate.class.php on line 370
PHP Stack trace:
PHP 1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate\update.php:0
PHP 2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\extensions\Localisa
tionUpdate\update.php:32
PHP 3. LocalisationUpdate::updateMediawikiMessages() C:\wamp\www\mw\extensions
\LocalisationUpdate\LocalisationUpdate.class.php:58
PHP 4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\extensions\Localisati
onUpdate\LocalisationUpdate.class.php:175
PHP 5. array_diff_assoc() C:\wamp\www\mw\extensions\LocalisationUpdate\Localis
ationUpdate.class.php:370

Warning: array_diff_assoc(): Argument #2 is not an array in C:\wamp\www\mw\exten
sions\LocalisationUpdate\LocalisationUpdate.class.php on line 370

Call Stack:

0.0019     642296   1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate

\update.php:0

0.2241   16614104   2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\e

xtensions\LocalisationUpdate\update.php:32

0.2241   16614344   3. LocalisationUpdate::updateMediawikiMessages() C:\wamp

\www\mw\extensions\LocalisationUpdate\LocalisationUpdate.class.php:58

53.3661   17563600   4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\ext

ensions\LocalisationUpdate\LocalisationUpdate.class.php:175

54.3005   17797480   5. array_diff_assoc() C:\wamp\www\mw\extensions\Localisa

tionUpdate\LocalisationUpdate.class.php:370


When adding one message in the messages array, it works.


Version: unspecified
Severity: normal
Whiteboard: aklapper-moreinfo

Details

Reference
bz30433

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:56 PM
bzimport set Reference to bz30433.
bzimport added a subscriber: Unknown Object (MLST).

This seems to have worked for r94830. Using qug as interface language on WMF wikis worked.

Could you provide more detailed steps to reproduce?

SPQRobin: Could you provide more detailed steps to reproduce?

SPQRobin: Could you provide more detailed steps to reproduce?

Aklapper changed the task status from Open to Stalled.Nov 25 2014, 7:47 PM
Aklapper claimed this task.
Aklapper subscribed.

Unfortunately closing this report as no further information has been provided.

@SPQRobin: Please feel free to reopen this report if you can provide the information asked for and if this still happens. Thanks!