Page MenuHomePhabricator
Create Task
Maniphest T32601

Error in preferences confusingly reported on first tab rather than on the tab where it occurs
Closed, ResolvedPublic
Actions

Description

Version: http://www.mediawiki.org/wiki/Special:Version

Go to http://www.mediawiki.org/wiki/Special:Preferences#preftab-5 (watchlist tab) and change Days to show in watchlist: to 10. Try Save.

The result will report "There are problems with some of your input" on the first tab, but there is no problem on this tab. Carefully opening each tab may find the problem (there is a max of 7 on the watchlist days), but this behaviour is highly confusing. Either a hint about what the error may be should be displayed on the first tab (including the tab name), or the tab opened directly (difficult perhaps if more than one tab is affected).

Version: unspecified
Severity: normal

Details

Reference
bz30601

Event Timeline

• bzimport raised the priority of this task from to High.Nov 21 2014, 11:56 PM
• bzimport added a project: MediaWiki-Core-Preferences.
• bzimport set Reference to bz30601.
• bzimport added a subscriber: Unknown Object (MLST).
G.Hagedorn created this task.Aug 28 2011, 10:16 AM
duplicatebug added a comment.Mar 2 2013, 10:19 AM

Fix of bug 27559 makes this nicer, but when the error is not on the last changed tab, you will not see it and cannot reach the tab without reload of the page.

• brion added a comment.Sep 25 2013, 4:37 PM

Validation should really be done during input, so you don't have to go through a form-submission bubble... This may need to be tied to a larger prefs UX update.

Aklapper added a comment.Mar 11 2014, 2:21 PM

Link is now https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-watchlist
Setting it to 10 shows "Your preferences have been saved." on https://www.mediawiki.org/w/index.php?title=Special:Preferences&success=1

Hence above testcase for 10 days is now obsolete as bug 11612 got fixed.
However, bug 26022 states the current limit is 30 days.

So entering a value higher than 30 triggers "There are problems with some of your input: The value you specified is above the maximum of 30" which is displayed on the same tab.

Closing as FIXED, for followup of explaining the maximum value before trying to set a value, see bug 26022.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL