| Yamaha5 | |
| Sep 3 2011, 1:17 PM |
| F8240: 30729.patch | |
| Nov 21 2014, 11:55 PM |
in fa.wiki abuse filter's raw numbers are in English would you please convert them to Persian one
http://fa.wikipedia.org/wiki/%D9%88%DB%8C%DA%98%D9%87:%D9%BE%D8%A7%D9%84%D8%A7%DB%8C%D9%87_%D8%AE%D8%B1%D8%A7%D8%A8%DA%A9%D8%A7%D8%B1%DB%8C
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Invalid | None | T40638 [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone] | ||
| Resolved | Logicwiki | T32729 Not all numbers are localised in AbuseFilter | ||
| · · · |
Should be just formatNum()s sprinkled in the code. Maybe the extension author could do it easily?
Created attachment 9070
Fixes the non-localized numbers
Since the bug is already assigned to someone, I didn't commit the change but rather post it here to assist Srikanth with fixing the bug.
Attached:
Thanks Huji. There are more places which needs the fix. I am hitting over AbuseFilterViewRevert.php for sometime now and hopefully get all of them soon.
Should the input also be modified to accept i18n numerals ? Special:AbuseFilter/test/ page has option to load a filter by ID.
I don't think so. In other places where MediaWiki accepts numbers, it always expects them to be in English-style numerals. I think it is a good practice to stick to the tradition in extensions too.
Fixed with r100016. Sorry, I was not aware of this bug. It was not my intention to "steal" an easy bug from a novice developer.