Page MenuHomePhabricator

Change in parser behavior in tables
Closed, ResolvedPublic

Description

Author: dasch

Description:
The correct parser behaviour that table row defintions that follow each other without a filled line is broken in current SVN Version

from

-
-

there should no empty line be added


Version: 1.20.x
Severity: normal

Details

Reference
bz30746

Related Objects

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:56 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz30746.
bzimport added a subscriber: Unknown Object (MLST).

Can you provide a full example & the before & after renderings?

(In reply to comment #2)

This are mainly the same (the map is missing an wecowi)
http://de.wikipedia.org/wiki/Vorlage:Infobox_Ort_in_den_Vereinigten_Staaten
http://www.wecowi.de/wiki/Vorlage:Infobox_Ort_in_den_Vereinigten_Staaten

important are the lines at the end

Could clarify what we should be looking for? It's hard to spot the relevant issue in these two links. Is it all of the horizontal grey lines in the info box that are close to each other?

dasch wrote:

yes... that are the unused empty tbale rows that should not be there (this behavior is also documented in wikipedias help for creation of templates)

works on HEAD... have to check 1.18 with r96887.

dasch wrote:

still the same in r96992

Simpler test code:

{| class="wikitable sortable"
! Header text

-
Example
-
Example
-
Example
- class="hintergrundfarbe2"
- class="hintergrundfarbe2"
- class="hintergrundfarbe2"
-
-
}

Aaron, thanks for the simpler test case, this was driving me bonkers.

Test case WORKSFORME on 1.18 and trunk

(In reply to comment #13)

Test case WORKSFORME on 1.18 and trunk

Not for me.

dasch wrote:

I think it should not me called WORKSFORME but WORKSFOREVERONE

(In reply to comment #15)

I think it should not me called WORKSFORME but WORKSFOREVERONE

Sure, but the tester can't test everyone's, only "mine".

Could you install MW from the 1.18 branch and see if you can reproduce? That's what I did and it WORKSFORME

dasch wrote:

Well I have another testinstallation and updated it to the latest branch of 1.18
The lines at the end does not appear, therfore a <> on top
http://mw-1-18.wecowi.de/phase3/index.php/30746

dasch wrote:

I would suggest Mark to repeat the test with enabled HTML-Tidy

dasch wrote:

I extended the test a bit, to show the different behaviour between 1.17 and later versions with tidy enabled and disabled

{| class="wikitable sortable"
! Header text

-
Example
-
Example
-
Example
- class="hintergrundfarbe2"
- class="hintergrundfarbe2"
- class="hintergrundfarbe2"
-
-
}

<table class="wikitable">
<tr><td>Example</td></tr>
<tr></tr>

</table>

<table class="wikitable">
<tr><td>Example</td></tr>
<tr><td></td></tr>
</table>

1.17 - http://www.mediawiki.org/wiki/User:DaSch/30746
1.18 (no tidy) - http://mw-1-18.wecowi.de/phase3/index.php/30746
1.19 (tidy) - http://www.wecowi.de/wiki/WeCoWi:Bug/30746

The nice thing is, that the rows with class generate broken HTML that is fixed by tidy. I think that the parser should create valid HTML

r85922 has been reverted. Could you test with SVN Head?

dasch wrote:

works as it should
Thanks

Thanks! (I also verified, but it took me a while to figure out that I hadn't installed tidy yet on this box.)

Now, to get the revisions backported to 1.18.