Page MenuHomePhabricator

Lower Diacritics of Devanagari Hidden in Page Titles and Section Headings
Closed, ResolvedPublic

Assigned To
Authored By
Siddhartha-Ghai
Sep 7 2011, 8:55 PM
Referenced Files
F8074: New_Bitmap_Image_(2).jpg
Nov 21 2014, 11:50 PM
F8073: New_Bitmap_Image.jpg
Nov 21 2014, 11:50 PM
F8071: Opera_11.50_with_monobook_skin.png
Nov 21 2014, 11:50 PM
F8072: Safari_5.0.3(7533.19.4)_with_monobook_skin.png
Nov 21 2014, 11:50 PM
F8070: IE_8.0.7601.17514_with_Vector_skin.png
Nov 21 2014, 11:50 PM
F8068: Chrome_13.0.782.220_m_with_monobook_skin.png
Nov 21 2014, 11:50 PM
F8069: Firefox_6.0_with_monobook_skin.png
Nov 21 2014, 11:50 PM
F8067: Safari_5.0.3(7533.19.4)_with_vector_skin.png
Nov 21 2014, 11:50 PM

Description

The devanagari diacritics that appear below the alphabets are cut off in article titles and headings with border-bottom(the grey line) in hindi wikipedia.

The problem is present in the vector and monobook skins atleast. Haven't checked out the other skins yet.

In the vector skin, the problem might be with the padding-bottom for these. The solution would require browser-specific css.

The headings problem can be seen(even by those who dont recognise devanagari at http://hi.wikipedia.org/wiki/%E0%A4%B8%E0%A4%A6%E0%A4%B8%E0%A5%8D%E0%A4%AF:Siddhartha_Ghai/sandbox05 ).


Version: unspecified
Severity: normal

Details

Reference
bz30809

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:50 PM
bzimport set Reference to bz30809.

Windows 7 Home Basic SP1, Chrome 13.0.782.220 m, vector skin

Attached:

Chrome_13.0.782.220_m_with_vector_skin.png (561×113 px, 8 KB)

Windows 7 Home Basic SP1, Firefox 6.0, vector skin

Attached:

Firefox_6.0_with_Vector_skin.png (582×120 px, 7 KB)

This ultimately looks similar to bug 29405, though on the other side -- there the risers go too far up and get cut off, here the descenders go too far down and get cut off.

In both cases, the header element has an 'overflow: hidden' style, which causes anything going outside the box area to get clipped and hidden instead of spilling over the edge.

Note that I have trouble reproducing this cutoff issue on my Linux or Mac machines, but can definitely see it on Windows. Seems to vary depending on the font & font rendering system, you end up with less or more space...

Windows 7 Home Basic SP1, IE8.0.7601.17514, vector skin

Attached:

IE_8.0.7601.17514_with_Vector_skin.png (573×113 px, 7 KB)

Windows 7 Home Basic SP1, Opera 11.50, vector skin

This is the only one without a problem that I've seen so far.

Attached:

Opera_11.5_with_Vector_skin.png (595×123 px, 7 KB)

Windows 7 Home Basic SP1, Safari 5.0.3(7533.19.4), vector skin

Attached:

Safari_5.0.3(7533.19.4)_with_vector_skin.png (621×119 px, 7 KB)

Windows 7 Home Basic SP1, Chrome 13.0.782.220 m, monobook skin

Attached:

Chrome_13.0.782.220_m_with_monobook_skin.png (626×129 px, 7 KB)

Windows 7 Home Basic SP1, Firefox 6.0, monobook skin

Attached:

Firefox_6.0_with_monobook_skin.png (588×112 px, 9 KB)

Windows 7 Home Basic SP1, IE8.0.7601.17514, monobook skin

Attached:

IE_8.0.7601.17514_with_Vector_skin.png (573×113 px, 7 KB)

Windows 7 Home Basic SP1, Opera 11.50, monobook skin

Again, this is the only one which works.

Attached:

Opera_11.50_with_monobook_skin.png (582×95 px, 7 KB)

Windows 7 Home Basic SP1, Safari 5.0.3(7533.19.4), monobook skin

Attached:

Safari_5.0.3(7533.19.4)_with_monobook_skin.png (614×107 px, 9 KB)

  • This bug has been marked as a duplicate of bug 29405 ***

Bug 29405 only lists the problem with the article title, not that with the section headings. r97788 fixes only the title, not the section headings.

Also, the problem might arise anywhere there's a top or bottom border, but I haven't checked that yet.

Discussed this with Trevor, and he proposed language specific css rules, otherwise it will affect other languages too. r97788 was reverted and r99389 addresses this in language specific way. Will get it reviewed by Trevor again.

Closing this a little late, but fixes were made in r99389, r104160, r105517, r105521.

(In reply to comment #15)

Closing this a little late, but fixes were made in r99389, r104160, r105517,
r105521.

Problem is down but not out. The #firstHeading property(line-height:1.2em) seems to be overriding the language-specific css(line-height:1.5em). I'm seeing this behaviour in chrome 16.0.912.63 m and firefox 8.0 with windows 7 Home Basic X64 SP1.

However, adding an !important to the language-specific css seems to solve the problem.

Chrome 16.0.912.63 m behaviour

Attachment for comment 16

Attached:

New_Bitmap_Image.jpg (643×1 px, 305 KB)

Chrome 16.0.912.63 m behaviour with !important

Attachment for comment 16 showing possible fix.

Attached:

New_Bitmap_Image_(2).jpg (643×1 px, 297 KB)

Santhosh, can you have a look at this? IIRC we did add an !important somewhere already...