When user enters confirmation code for second time, we show misleading error message
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• howief
	Sep 8 2011, 9:12 PM

Description

On the English Wikipedia: Submit email for email capture (eg., via AFT --> click on "I am highly knowledgeable about this topic and fill in email field)
Wait for Wikimedia email with confirmation instructions
Click on manual confirmation link (http://en.wikipedia.org/wiki/Special:EmailCapture). Enter confirmation code. Should get message stating email address has been confirmed.
Click on manual confirmation link again. Enter confirmation code again.
Should get message stating email address has NOT been confirmed.
User should get message stating "Email address has already been confirmed"

Version: unspecified
Severity: normal

• bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:51 PM

• bzimport set Reference to bz30823.

• bzimport added a subscriber: Unknown Object (MLST).

This seems to be in the EmailCapture extension, which has its own table of addresses and confirmation codes.

Current code attempts to update the row with the matching code to add the verified bit, then claims failure if no rows were changed.

Should probably instead check for presence of a current row, and if it's present and already verified it could then give a different err msg.

r96627 should fix this -- presumably needs backport for deployment.

(In reply to comment #2)

r96627 should fix this -- presumably needs backport for deployment.

Awesome. Thanks!