Page MenuHomePhabricator

Distinguish external links from internal links.
Closed, ResolvedPublic

Description

External links should be visually distinguished from internal links, through applying css styles to a.external links to add external link icons:

http://bits.wikimedia.org/skins-1.17/vector/images/external-link-ltr-icon.png

and the others:

http://www.mediawiki.org/wiki/Help:Links#External_link_icons


Version: unspecified
Severity: enhancement

Details

Reference
bz30831

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:51 PM
bzimport set Reference to bz30831.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 10004
Adds an external link icon to external links

Note this uses the image suggested however we may want to use another or use a relative url instead of the absolute url.

Attached:

sumanah wrote:

Jon,

Since this patch awaits review, I've added the "patch" and "need-review" keywords. Next time, you can save time by doing this yourself! Check out https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Submit_your_changes Thanks.

fixed in r112608
Note fix uses a data image uri. We probably want to fallback to an image file for older browsers - for that I left a TODO note as I wasn't sure where to point to without creating a new image in the repository.