While testing on test2.wikipedia.org I noticed a few issues that need taking care of:
Version: 1.18.x
Severity: normal
URL: http://test2.wikipedia.org/wiki/Islam?uselang=he
TheDJ | |
Sep 20 2011, 9:22 AM |
F8206: Screen_shot_2011-09-20_at_18.53.26.png | |
Nov 21 2014, 11:54 PM |
F8205: Screen_shot_2011-09-20_at_11.19.59.png | |
Nov 21 2014, 11:54 PM |
F8204: Screen_shot_2011-09-20_at_11.19.43.png | |
Nov 21 2014, 11:54 PM |
F8203: Screen_shot_2011-09-20_at_11.19.53.png | |
Nov 21 2014, 11:54 PM |
While testing on test2.wikipedia.org I noticed a few issues that need taking care of:
Version: 1.18.x
Severity: normal
URL: http://test2.wikipedia.org/wiki/Islam?uselang=he
Created attachment 9079
positioning of FlaggedRevs element is always top right
Attached:
Created attachment 9080
Image positioned at the left but using margins for right aligned element
Attached:
Ah no, the image is indeed at the left side (..|thumb|left|..), so the margin is changed due to local CSS as well.
the toc is due to the <h2> being rtl. that flips the bidi logic on OS X I think. If I make that text latin script, it seems to be working.
The TOC title issue is fixed with r97622. (Needs merging & software update.)
This bug could be closed, but we might leave it open because I assume more BiDi bugs will pop up :)
FYI, fixed the CSS for the infobox & image: http://test2.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&action=historysubmit&diff=34980&oldid=34681
I don't quite understand why should this be customized on-wiki and not fixed in the source.
I added this to div.flaggedrevs_short at FlaggedRevs/presentation/modules/flaggedrevs.css :
position: absolute;
right: 0em;
top: -4em;
This fixed the problem nicely for LTR and RTL.
It's a workaround, it's a bit ugly, it may have to be improved a little more, but it's better than customizing Common.css.
There's no problem with the FlaggedRevs box, it aligns correctly according to the page content direction. The problem was with the infobox using local CSS float:right; which is flipped to float:left; causing the infobox to display at the left side, which is wrong. I added @noflip so the infobox CSS is not flipped. (Same for the image).
Awesome. You can make the changes already on MediaWiki:Common.css, it won't break anything.
Also something that should be tested...
All the skins...
http://test2.wikipedia.org/wiki/Islam?uselang=he&useskin=standard
Per IRC, r96760 will be merged (it was a follow-up to a rev that was already merged).
Created attachment 9081
Screenshot of skin=standard breakage in mixed ltr/rtl mode
Attached:
Yeah, this has been broken since it exists, see http://he.wikipedia.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99?useskin=standard&uselang=he
Fixed it anyway in r97657.
All issues reported here were fixed or followed up. It could be re-opened when new RTL/BiDi regressions appear.