Page MenuHomePhabricator

$wgEnotifUseJobQ shouldn't unconditionally unqueue jobs
Closed, ResolvedPublic

Description

With $wgEnotifUseJobQ enabled, a job is queued unconditionally, regardless of whether any emails will be sent. The relevant logic for deciding who to send emails to is implemented in actuallyNotifyOnPageChange(), which is common to job execution and non-job email sending.

This is especially obvious with $wgEnotifWatchlist=false and $wgEnotifUserTalk=true, as it is on enwiki. The page title is not checked to see if it is a user talk page before the job is queued, so more than 90% of queued jobs are no-ops.


Version: 1.17.x
Severity: normal

Details

Reference
bz31081