Page MenuHomePhabricator

[Regression] "Create account/log in" should use the current title and query in returnto
Closed, ResolvedPublic

Description

Just noticed this since MW.org is running 1.18wmf1.

When going to a link like: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#code-comments

Logging in will go back to the main "Special:Code", not to "MediaWiki/94951".


Version: 1.18.x
Severity: major

Details

Reference
bz31088

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:47 PM
bzimport set Reference to bz31088.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

Just noticed this since MW.org is running 1.18wmf1.

When going to a link like:
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#code-comments

Logging in will go back to the main "Special:Code", not to "MediaWiki/94951".

Now, is that definitely a CR regression, or may it actually be MW itself?

This is core; you can see it with Special:Version/foo as well.

Looks like it may be related to the context stuff; $this->thispage on SkinTemplate (now retrieved via $this->getTitle() as a context goodie) turns up with the short name (paramter removed), so it doesn't get passed on when we build the returnto link.

Can't repro on r85252 (just after it was switched from $this->mTitle to $this->getTitle), so the title object is getting corrupted somewhere else in the stack.

(In reply to comment #3)

Can't repro on r85252 (just after it was switched from $this->mTitle to
$this->getTitle), so the title object is getting corrupted somewhere else in
the stack.

Is that the right rev #?