Page MenuHomePhabricator

Remove feature requested with bug #25295
Closed, ResolvedPublic

Description

Author: matthiasbecker1967

Description:
After feature request 25295 was resolved any reviewer can see who in that moment is reviewing the article. Worse it does not need to click on "review" ("sichten in the German language interface) but appearantly any viewing of a diff link results in this.

I consider this new feature as critical since it can be misused for profiling other users or to make conclusions wether an article is on a user's watch list.

  • The feature should be removed BEFORE the great update which lies only a few days ahead. **

See:

http://de.wikipedia.org/wiki/Datei:Sichten2.png

Greetings, Matthias


Version: unspecified
Severity: critical
URL: http://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Tester_gesucht:_Neue_Version_der_FlaggedRevs-Erweiterung_kommt

Details

Reference
bz31093

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:48 PM
bzimport set Reference to bz31093.
bzimport added a subscriber: Unknown Object (MLST).

I agree that while the user is told about this behavior, we can't assume that any diff view by a user with reviewer permission is the beginning of the review process, and disclose their behavior to others. If that's the current behavior, we shouldn't deploy it.

I can see that sharing this information as part of the process could be useful, but I would suggest an AJAX opt-in link on the diff view:

"Show other users that I, Eloquence, am reviewing this page now."

That would actually keep the UI at the current level of complexity since the message could be replaced with the yellow indicator message once the link has been clicked.

(In reply to comment #0)

After feature request 25295 was resolved any reviewer can see who in that
moment is reviewing the article. Worse it does not need to click on "review"
("sichten in the German language interface) but appearantly any viewing of a
diff link results in this.

I consider this new feature as critical since it can be misused for profiling
other users or to make conclusions wether an article is on a user's watch list.

  • The feature should be removed BEFORE the great update which lies only a few

days ahead. **

See:

http://de.wikipedia.org/wiki/Datei:Sichten2.png

Greetings, Matthias

Even on 1.17 you don't have to click the "review" diff links (e.g. at Special:PendingChanges). The main difference now is that:
(a) The user is told that they are advertised as reviewing the page
(b) Other users are notified that "user X is already reviewing" when they also view the diff.

I think people understand that. They are objecting that their username is disclosed without their permission when they may be looking for the diff for other reasons, or may only want to apply an initial gut-feel judgment to the page, but not necessarily review it.

(In reply to comment #3)

I think people understand that. They are objecting that their username is
disclosed without their permission when they may be looking for the diff for
other reasons, or may only want to apply an initial gut-feel judgment to the
page, but not necessarily review it.

Right. I'm trying to clarify the difference in behavior. I already have a patch to disable setting the notice except from the (review) link on the special pages.

Users must now click a JS link to have them treated as reviewing a page/diff since r97886.

(In reply to comment #5)

Users must now click a JS link to have them treated as reviewing a page/diff
since r97886.

A few more tweaks made. Fixed on trunk.