Page MenuHomePhabricator
Create Task
Maniphest T33169

Paraminfo for upload module is broken
Closed, ResolvedPublic
Actions

Description

Author: a.d.bergi

Description:
Trying to call paraminfo for the upload module returns a technical error:

PHP fatal error in /usr/local/apache/common-local/php-1.17/includes/api/ApiUpload.php line 497:
Call to undefined method ApiUpload::getRequireOnlyOneParameterErrorMessages()

I'm not sure what this method should do (rarely documented in ApiBase) and I'm not an PHP expert, but I guess its about line 582 (see applied patch).

Version: unspecified
Severity: major
URL: http://de.wikipedia.org/w/api.php?action=paraminfo&modules=upload

Details

Reference
bz31169

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:53 PM
• bzimport added a project: MediaWiki-Action-API.
• bzimport set Reference to bz31169.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Sep 26 2011, 6:13 PM
• bzimport added a comment.Sep 26 2011, 6:16 PM

a.d.bergi wrote:

proposed patch

attachment bug31169 paraminfo ApiUpload.patch ignored as obsolete

Reedy added a comment.Sep 26 2011, 6:16 PM

http://en.wikipedia.org/w/api.php?action=paraminfo&modules=upload

http://test2.wikipedia.org/w/api.php?action=paraminfo&modules=upload

It's already fixed in 1.18

I've got a feeling I might've backported it

Reedy added a comment.Sep 26 2011, 6:19 PM

(In reply to comment #1)

Created attachment 9103 [details]
proposed patch

Nope, this isn't the fix, the parent method isn't a static method

attachment bug31169 paraminfo ApiUpload.patch ignored as obsolete

Reedy added a comment.Sep 26 2011, 6:21 PM

It's also fine on trunk

http://translatewiki.net/w/api.php?action=paraminfo&modules=upload

It's due to a bad merge in 1.17wmf1

http://svn.wikimedia.org/viewvc/mediawiki/branches/wmf/1.17wmf1/includes/api/ApiUpload.php?view=markup

It's not in REL1_17

http://svn.wikimedia.org/viewvc/mediawiki/branches/REL1_17/phase3/includes/api/ApiUpload.php?view=markup

Reedy added a comment.Sep 26 2011, 6:22 PM

r98153

• bzimport added a comment.Sep 26 2011, 6:30 PM

a.d.bergi wrote:

Thanks, that was fast :-)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL