Page MenuHomePhabricator

MediaWiki mailer sends protocol-relative URLs on en.wp
Closed, ResolvedPublic

Description

E-mail notifications on the English Wikipedia currently contain protocol-relative URLs, because the user interface message http://en.wikipedia.org/wiki/MediaWiki:Enotif_body contains protocol-specific (HTTP) URLs that are transformed into protocol-relative ones.

Steps to reproduce: Obtain an email notification from an English Wikipedia talk page modification.

Expected behavior: URLs are disseminated as is, or are transformed to use $wgCanonicalServer

Actual behavior: The email contains the following text:


This email notification feature was enabled on English Wikipedia in May
2011 - see en.wikipedia.org/wiki/Help:Email_notification. If you would
like to switch off your notifications, visit
en.wikipedia.org/wiki/Special:Preferences

Feedback and further assistance:
//en.wikipedia.org/wiki/Help:Contents


Version: unspecified
Severity: normal

Details

Reference
bz31181
TitleReferenceAuthorSource BranchDest Branch
Add tests for get-coderepos/releng/cli!383addshorefirst-tests-for-get-codemain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:54 PM
bzimport added a project: MediaWiki-Email.
bzimport set Reference to bz31181.
bzimport added a subscriber: Unknown Object (MLST).

I though I'd fixed all of the enotif_body messages, but I didn't think about local overrides. Fixed the one on enwiki just now, I'll see which other wikis have a local override for enotif_body.

(In reply to comment #1)

I though I'd fixed all of the enotif_body messages, but I didn't think about
local overrides. Fixed the one on enwiki just now, I'll see which other wikis
have a local override for enotif_body.

Sam and I have fixed all of them now.