Page MenuHomePhabricator

"My new messages" badge number is wrong
Closed, DeclinedPublic

Description

Author: sumanah

Description:
there are no new messages, yet the indicator says 1

Right now mediawiki.org says I have 1 new message (via "My new messages (1)" in the list of links at the top), but gives me "There are no new messages for you." at Special:NewMessages. See attached screenshot.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=46838

Attached:

no-new-messages.png (279×1 px, 70 KB)

Details

Reference
bz31251

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:48 PM
bzimport set Reference to bz31251.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 31275 has been marked as a duplicate of this bug. ***

Created attachment 9131
I have 27 new invisible messages... =P

Copying from the dupe bug

Attached:

LQT_bug.png (768×1 px, 98 KB)

  • Bug 31319 has been marked as a duplicate of this bug. ***

See also:

  • bug 24292
  • bug 20644
  • bug 28579

Created attachment 9164
18 "new" messages

Interesting side note: A few minutes I ago I actually had 18 new messages and I clicked the link to read them. Then when I was done, and refreshed the messages were no longer there but the link still reads "18" and hours later still does.

Attached:

Screen_Shot_2011-10-05_at_11.22.19_PM.png (168×638 px, 19 KB)

Seen on [[WP:VPT]]: "liquidthreads problem at en.wiktionary"

On en.wiktionary, I see "my new messages (1)" in bold, but when I click on it, it says "There are no new messages for you.".

  • Bug 31416 has been marked as a duplicate of this bug. ***

sumanah wrote:

Still happening on MediaWiki.org for me, 1.20wmf2 (c29337d).

Yeah, mine's still stuck at 18. I've gotten used to it. I'm all excited when I got 19 (which means 1). :D

Oh, same problem in my wiki: "my new messages (3)"

How can I reset the number to none in database?

Valerie.m.juarez wrote:

If this is a dup of bug 24292, that bug has been fixed. Can those who were affected by this bug tell me if they are still affected or if it was fixed?

Currently there doesn't seems to be a way to show all new messages in only one page, so I did the following:

  1. Opened https://www.mediawiki.org/wiki/Special:NewMessages
  2. Opened "Next page" in a new tab
  3. Repeated step 2 until there was no "Next page" link
  4. Executed "$('.lqt_post_new_message ').length" in the console for each of the tabs and summed the results:

25+28+25+25+30+25+26+25+25+29+21 === 284

Nonetheless, LQT says I have 286 unread messages, so I don't think this is fixed.

I guess this bug should affect all?

when I tried to mark all my new messages as read and refreshed the page I didn't find any new messages and the count was rightly 0. In fact this bug has never occurred to me. Did others use some special steps to reproduce? ;)

This happens constantly in a normal work situation:

  1. New messages n (when n > 0) :)
  1. Go to http://www.mediawiki.org/wiki/Special:NewMessages
  1. Open another page at mediawiki.org

At this point both pages are showing n messages. Good.

  1. Reply to one of the threads at http://www.mediawiki.org/wiki/Special:NewMessages
  1. "Mark as read" the thread you just reply.

At this point both pages are showing still n messages. Not so good.

  1. Go to the second page you opened and click any link pointing to another mediawiki.org page.
  1. Check the header of the newly loaded mediawiki.org page.

At this point the second pages is still showing n messages. Very bad.

You can keep clicking links in the second tab and jumping to other pages at mediawiki.org. n messages are still shown.

It seems that only clicking to "New messages (n)" directly will change the score to "New messages (n-1)". Very very bad, and what this bug is about.

Ideally the score would be updated live whenever a thread is marked as read.

As a second (and last) choice, the score should be updated whenever a new page is loaded.

(after just some more clicks in normal work conditions):

... and even after clicking to "New messages (n-1)" you might get a wrong count if you have been marking threads as read at http://www.mediawiki.org/wiki/Special:NewMessages relying, changing pages in other tabs...

But if the sync between "Mark as read" and the counter in the header is improved, there is a chance that all this family of bugs will be solved at once.

Quim, thanks for such a detailed explanation.

I was easily able to reproduce this on MW.org but not on my local wiki; there on clicking 'Mark as read' the 'New messages(n)' completely disappears (I thought that was another bug) and on refreshing the count is very right. So confused I am now :p

p.s. Yes, I have the latest LQT

  • Bug 28579 has been marked as a duplicate of this bug. ***

(In reply to comment #16)

p.s. Yes, I have the latest LQT

Interesting. Then the question perhaps is: does mediawiki.org have the latest version?

http://www.mediawiki.org/wiki/Special:Version says "Version 2.1-alpha" but what snapshot? For instance, https://www.mediawiki.org/wiki/Extension:LiquidThreads points "Version 2.1-alpha" to https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/LiquidThreads.git;a=commitdiff;h=20800acaee6a3ceb732d93faa12786fa7bf0397a;ds=sidebyside (2012-09-21).

http://translatewiki.net/wiki/Special:Version says also "Version 2.1-alpha", but pointing to https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/LiquidThreads.git;h=d4f1a8b8b014694962c6426c09b5b11e7477df1c (2013-04-19). Can this problem be found in translatewiki.net or is it fixed there?

I just saw "New messages (1,406)" in my personal tools on mediawiki.org, and when I clicked the link, the value changed to "New messages (644)" (I didn't mark any message as read - just followed the link to [[mw:Special:NewMessages]]).

(In reply to comment #19)

I just saw "New messages (1,406)" in my personal tools on mediawiki.org, and
when I clicked the link, the value changed to "New messages (644)" (I didn't
mark any message as read - just followed the link to
[[mw:Special:NewMessages]]).

And it keeps going back and forward from around 500 messages to a few more than 1000.

(In reply to comment #20)

And it keeps going back and forward from around 500 messages to a few more
than 1000.

It still overestimates the number of messages in my first visit to [[mw:Special:NewMessages]] as being 958, and goes back to 572 after some clicks on "Next page".

sumanah wrote:

I don't think I can still reproduce this.