Page MenuHomePhabricator

InstantCommons tif thumbnails should work without $wgTiffThumbnailType set on local wiki
Closed, ResolvedPublic

Description

.tif thumbnails from a foreign repo (Wikimedia Commons) don't work on a local wiki, unless $wgTiffThumbnailType is specified in LocalSettings.php:

$wgTiffThumbnailType = array( 'jpg', 'image/jpeg' );

These thumbnails should just work, regardless if $wgTiffThumbnailType is set on the local wiki.


Version: 1.20.x
Severity: normal

Details

Reference
bz31282

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:50 PM
bzimport set Reference to bz31282.

Fixed in r98812, marking for 1.18 etc.

This feels a bit hacky -- TiffHandler::canRender() right now checks the local tiff thumbnailing settings to decide if we can render thumbs or not, but for files loaded over ForeignAPIRepo we generally are using premade thumbnails from somewhere else and it doesn't matter if we could create them locally.

May wish to do further refactorings on the file, file repo, and media handler APIs to better distinguish between things that need to be done locally and things that don't.

Note that there are other things like multipage support that are also broken in this configuration...

Starting to collect some notes for further work at [[mw:Requests for comment/Refactor on File-FileRepo-MediaHandler]].

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM