Page MenuHomePhabricator
Create Task
Maniphest T33362

Lost CSS styles in pages transcluding pages from the Special: namespace
Closed, ResolvedPublic
Actions

Description

Author: vlakoff

Description:
Hello,

Here is an issue related to the recent 1.18 deployment. Some pages do include {{Special:Prefixindex/something}}. They were usually relying on the CSS property "width:98%" of #mw-prefixindex-list-table, among others properties I guess, but now this property is loaded from another file, specific to the Special: pages, i.e. http://bits.wikimedia.org/fr.wikipedia.org/load.php?debug=true&lang=fr&modules=mediawiki.special&only=styles&skin=vector

So, the pages that are including a page from the Special: namespace lost these CSS styles.

For example, compare http://fr.wikipedia.org/wiki/Sp%C3%A9cial:Index/Utilisateur:Od1n/ with http://fr.wikipedia.org/wiki/Utilisateur:Od1n/Sous-pages ; before, the latter had a 98 % width as the former.

So basically, the styling system is now written to only include the styling for Special pages on special pages, incorrectly assuming that Special pages are not transcludeable.

Version: 1.18.x
Severity: major

Details

Reference
bz31362

Event Timeline

• bzimport raised the priority of this task from to High.Nov 21 2014, 11:56 PM
• bzimport added projects: MW-1.18.0-release, MediaWiki-General.
• bzimport set Reference to bz31362.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Oct 5 2011, 1:19 AM
He7d3r added a comment.Oct 5 2011, 1:24 PM

This has being reported also on Village Pump:
https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=454067107#Special:PrefixIndex

Krinkle added a comment.Oct 5 2011, 9:58 PM

Not sure what the 'proper' solution is, but I think either the parser needs to detect the modules added by the special page being transcluded and copy those to it's own modules queue, or the specialpage class for PrefixIndex needs to specifically add the modules when trancluding as well.

Bawolff added a comment.Oct 8 2011, 11:34 PM

(In reply to comment #2)

Not sure what the 'proper' solution is, but I think either the parser needs to
detect the modules added by the special page being transcluded and copy those
to it's own modules queue, or the specialpage class for PrefixIndex needs to
specifically add the modules when trancluding as well.

Well the specialpage class doesn't really have access to the parser object or the OutputPage object when transcluding, so it can't really add them. Merging the modules used in SpecialPageFactory::capturePath is probably the right solution

This bug does not appear to be present on trunk. I'm not sure why...

Bawolff added a comment.Oct 8 2011, 11:56 PM

This bug does not appear to be present on trunk. I'm not sure why...

Apparently on trunk it got fixed as part of r93758

MarkAHershberger added a comment.Oct 15 2011, 6:42 PM

need to verify that this works in 1.17. If it doesn't then take off the regression bit.

tstarling added a comment.Oct 15 2011, 6:47 PM

Confirmed that it works in 1.17.

MarkAHershberger added a comment.Oct 15 2011, 10:03 PM

tagging bugs for Marcus to look at

MarkAHershberger added a comment.Nov 2 2011, 5:10 PM

(In reply to comment #4)

This bug does not appear to be present on trunk. I'm not sure why...

Apparently on trunk it got fixed as part of r93758

Backported now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL