Page MenuHomePhabricator

Improve the display of [[MediaWiki:revreview-cancel]]
Closed, ResolvedPublic

Description

Author: danny.leinad

Description:
When no changes pending on review, there is no sense to display button [[MediaWiki:revreview-cancel]].

For example when I open page http://pl.wikipedia.org/wiki/Strona_g%C5%82%C3%B3wna, the button "Cancel" also contains the same url (http://pl.wikipedia.org/wiki/Strona_g%C5%82%C3%B3wna).


Version: unspecified
Severity: normal

Details

Reference
bz31376

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:57 PM
bzimport set Reference to bz31376.
bzimport added a subscriber: Unknown Object (MLST).

It is possible to use the form to unaccept pages, so a "cancel" button isn't *totally* useless there...though unlikely to be used when the revision is already accepted.

The button should probably only show if the user came from a certain urls, such as via ?cancenReviewTo=x and take the user back there.

The button only shows on diff pages as of r99131.