When file name contains characters which are not permitted the upload form shows a warning message while in fact this is a blocking error.
Version: 1.20.x
Severity: normal
Description
Description
Details
Details
- Reference
- bz31496
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Amire80 | T23778 BiDi issue in RTL wikis at site notice with LTR text ending with Unicode characters with neutral directional | |||
| Resolved | None | T31876 1.18 post-deployment actions (tracking) | |||
| Resolved | None | T33496 Error messages are described as warnings |
Event Timeline
Comment Actions
Created attachment 9209
Patch
Changed the description from warning to error (string already existed). As far as I can tell, this method (showRecoverableUploadError) is never called by warnings, only by errors (MIN_LENGTH_PARTNAME, ILLEGAL_FILENAME, FILENAME_TOO_LONG, FILETYPE_MISSING, WINDOWS_NONASCII_FILENAME and verifyTitlePermissions).
This is my first patch, please be gentle.
attachment SpecialUpload.php ignored as obsolete
Comment Actions
Any chance the patch could be attached in unified diff format ([[w:Diff#Unified_format]]).
Thanks.
Comment Actions
Created attachment 9218
Unified diff?
Like that?
attachment patch.txt ignored as obsolete
Comment Actions
Created attachment 9219
patch, unified diff
Better yet.
attachment patch.txt ignored as obsolete
Comment Actions
(In reply to comment #4)
Created attachment 9219 [details]
patch, unified diffBetter yet.
Yep, that's much better.
attachment patch.txt ignored as obsolete