Page MenuHomePhabricator

section links on file pages scroll too far down
Closed, ResolvedPublic

Description

So you lose the title and the first line or so


Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz31524

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:58 PM
bzimport set Reference to bz31524.

Can you attach a screenshot. I'm not seeing this happen on a Nexus One or Droid Incredible

Same for reflinks... Seems to scroll to the top of the window, not accounting for the search bar

Will do later, was done directly from my phone at the hola hotel. Phones not rooted, so need it attached to a computer to do a screenshot

Created attachment 9235
Images!

Attached:

20111014174341.png (800×480 px, 111 KB)

Ok, I think... we're actually ending up scrolling the parent document, not the iframe. The header is marked as position:fixed, which is why it doesn't scroll off screen with the rest of the document.

Not entirely sure if one-finger drag/scroll will work as expected if we make the main document fit the window and let the iframe scroll within itself.

I tried swapping it to make the iframe limited size; seems to be glitchy in different ways on both Android 2.x and 3/4:

https://github.com/brion/Wikipedia/tree/scroll-adjust

notes on https://github.com/brion/Wikipedia/commit/e2d3b32b6b93e82c4e0a1b1b3ece018bc217a21c

My 'absolute' branch resolves this by removing the 'position: fixed' floating toolbar and letting it scroll off the page:
https://github.com/brion/Wikipedia/commits/absolute

It also provides more screen space for reading, which is a big plus in portrait orientation where a toolbar eats proportionately more screen space.

philinje wrote:

Is this resolved?

Scrolling to references only work if you first expand the sections out (will log a bug fort hat)... But they do scroll to the correct place

Same for file pages

Guessing brions absolute branch fixed it

Marking it RESOLVED FIXED