Page MenuHomePhabricator

Ratings panel only partially displayed
Closed, ResolvedPublic

Description

From: http://en.wikipedia.org/w/index.php?diff=454572784

recently the ratings panel at the bottom of articles has been broken for me. I used to be able to see the current rating averages (via a "display ratings" link or something ... don't remember precisely what it was called). Now that has gone, there is a cryptic green arrow and blue box whose purposes are completely unclear, and when I assign a rating some unlabelled checkboxes and an email address, again all of unknown purpose, also appear. Basically it's all in a very broken-looking state, as if someone's currently in the middle of playing around with coding some new features but hasn't yet finished.


Version: unspecified
Severity: major

Details

Reference
bz31543

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:47 PM
bzimport added a project: ArticleFeedback.
bzimport set Reference to bz31543.
bzimport added a subscriber: Unknown Object (MLST).

Just above that:

IE9 in compatibility view mode:

  • Text "I am highly knowledgeable about this topic (optional)" does not show; after checking the box, other checkboxes show without accompanying text
  • Submit rating button is blank

Verified breakage in IE7 and IE6, cannot reproduce in IE8 or IE9. Escalating.

Created attachment 9337
Broken rendering in IE6

Attached:

aftie6.png (291×1 px, 15 KB)

Created attachment 9338
Broken rendering in IE7

Same bug as in IE6, widget is just in a different state.

Attached:

aftie7.png (266×1 px, 25 KB)

Per Erik's request I've blacklisted IE7 and below in r101461. This means ArticleFeedback will automatically disable itself in IE7 and below; this includes IE8+ in compatibility mode.

Unable to reproduce on IE8.0 (via browserstack)

(In reply to comment #6)

Per Erik's request I've blacklisted IE7 and below in r101461. This means
ArticleFeedback will automatically disable itself in IE7 and below; this
includes IE8+ in compatibility mode.

r101461 causes errors on IE7. This should be disabled much earlier, at the beginning of ext.articleFeedback.startup.js, otherwise it'll crash on IE7 at ext.articleFeedback.js, line 319, because $.articleFeedback is undefined.

(In reply to comment #10)

(In reply to comment #6)

Per Erik's request I've blacklisted IE7 and below in r101461. This means
ArticleFeedback will automatically disable itself in IE7 and below; this
includes IE8+ in compatibility mode.

r101461 causes errors on IE7. This should be disabled much earlier, at the
beginning of ext.articleFeedback.startup.js, otherwise it'll crash on IE7 at
ext.articleFeedback.js, line 319, because $.articleFeedback is undefined.

Moved in r103456.