Page MenuHomePhabricator

Some AJAX features seem to have stopped working in 1.18
Closed, ResolvedPublic

Description

Some AJAX features seem to have stopped working in 1.18. I report them together, because they seem related; if they are not related i'll split them.

  • When you click the "add to watchlist" star, the message "The page has been added to your watchlist" is shown. Since the move to Vector until 1.18 the star only changed its color, but now the pre-Vector is back. Somebody even reported that he gets a whole new page saying that the page was added to the watchlist.
  • When a patroller clicks "mark as patrolled", a new page is shown instead of doing the AJAX in-page thingy.
  • Some people reported that when they edit a page and click the "Preview button", they get the message "Some parts of the edit form did not reach the server", although i couldn't reproduce it myself. This only happens if the "Use live preview" preferences is enabled, which again hints at an AJAX issue.

This happens in Wikipedia (en, he, ru) and in my test wiki, which runs the latest trunk.


Version: unspecified
Severity: major

Details

Reference
bz31545

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:47 PM
bzimport set Reference to bz31545.
bzimport added a subscriber: Unknown Object (MLST).

Add to watchlist -- sounds like correct behavior. Not showing the message would be very mysterious and make the watchlist hard to discover in the first place.

Patrolling -- not sure offhand how to repro this easily. (Is patrolling even on on en?)

Live preview working ok for me on en.wikipedia.org.

(In reply to comment #1)

Add to watchlist -- sounds like correct behavior. Not showing the message would
be very mysterious and make the watchlist hard to discover in the first place.

It is OK behavior, but it was like this before the Vector upgrade in April 2010 (or so). Since the introduction of Vector this message was not displayed; I suppose that it was like this under the assumption that the changing of the color of the star is enough. So this is a change and i'm not sure that it was intended.

Patrolling -- not sure offhand how to repro this easily. (Is patrolling even on
on en?)

Try this:
http://he.wikipedia.org/w/index.php?title=Game_Boy_Advance&action=historysubmit&diff=11338376&oldid=11338073&uselang=en

And i'm really not sure that patrolling is on on en.

Live preview working ok for me on en.wikipedia.org.

For me too, but a few people complained about it. I don't really know what to say.

Patrolling -- not sure offhand how to repro this easily. (Is patrolling even on
on en?)

I believe new page patrolling is on, but RC patrolling is not. However its news to me that we've implemented fancy ajax stuff for patrolling, I thought all that was a gadget.

matmarex claimed this task.

No longer occurs.